From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933288AbdGSPoM (ORCPT ); Wed, 19 Jul 2017 11:44:12 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:37493 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932660AbdGSPoK (ORCPT ); Wed, 19 Jul 2017 11:44:10 -0400 Date: Wed, 19 Jul 2017 11:44:06 -0400 From: Tejun Heo To: Waiman Long Cc: lizefan@huawei.com, hannes@cmpxchg.org, peterz@infradead.org, mingo@redhat.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, efault@gmx.de, torvalds@linux-foundation.org, guro@fb.com Subject: Re: [PATCH 6/6] cgroup: update debug controller to print out thread mode information Message-ID: <20170719154406.GO3365493@devbig577.frc2.facebook.com> References: <20170717020721.3612468-1-tj@kernel.org> <20170717020721.3612468-7-tj@kernel.org> <20170719153105.GM3365493@devbig577.frc2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 19, 2017 at 11:41:09AM -0400, Waiman Long wrote: > On 07/19/2017 11:31 AM, Tejun Heo wrote: > > Hello, > > > > On Mon, Jul 17, 2017 at 05:19:16PM -0400, Waiman Long wrote: > >>> + if (cgroup_is_thread_root(css->cgroup)) > >>> + seq_puts(seq, "[thread root]\n"); > >>> + else if (cgroup_is_threaded(css->cgroup)) > >>> + seq_puts(seq, "[threaded]\n"); > >> The cgroup status will not be needed anymore as you have introduced the > >> cgroup.type control file that returns the proper information. > > Ah, right, will drop this file. > > > > Thanks. > > > Oh, I am not saying that we should drop the whole patch. I just want to > drop the above 4 line of codes as they are not needed. lol, yeah, that's me mis-writing. I'm gonna drop only the duplicate part. Thanks. -- tejun