[PATCH] soc: integrator: remove unnecessary static in integrator_soc_init()

[PATCH] soc: integrator: remove unnecessary static in integrator_soc_init()

[Gustavo A. R. Silva]

Remove unnecessary static on local variable syscon_regmap.
Such variables are initialized before being used, on every
execution path throughout the functions. So, the static has
no benefit.

This issue was detected using Coccinelle and the following
semantic patch:

@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/soc/versatile/soc-integrator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/versatile/soc-integrator.c b/drivers/soc/versatile/soc-integrator.c
index a5d7d39..e45638a 100644
--- a/drivers/soc/versatile/soc-integrator.c
+++ b/drivers/soc/versatile/soc-integrator.c
@@ -102,7 +102,7 @@ static struct device_attribute integrator_build_attr =
 
 static int __init integrator_soc_init(void)
 {
-	static struct regmap *syscon_regmap;
+	struct regmap *syscon_regmap;
 	struct soc_device *soc_dev;
 	struct soc_device_attribute *soc_dev_attr;
 	struct device_node *np;
-- 
2.5.0

Re: [PATCH] soc: integrator: remove unnecessary static in integrator_soc_init()

[Linus Walleij]

On Thu, Jul 20, 2017 at 12:39 AM, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:

> Remove unnecessary static on local variable syscon_regmap.
> Such variables are initialized before being used, on every
> execution path throughout the functions. So, the static has
> no benefit.
>
> This issue was detected using Coccinelle and the following
> semantic patch:
>
> @bad exists@
> position p;
> identifier x;
> type T;
> @@
>
> static T x@p;
> ...
> x = <+...x...+>
>
> @@
> identifier x;
> expression e;
> type T;
> position p != bad.p;
> @@
>
> -static
>  T x@p;
>  ... when != x
>      when strict
> ?x = e;
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

You probably want to funnel this patch through the ARM SoC tree.

Yours,
Linus Walleij

Re: [PATCH] soc: integrator: remove unnecessary static in integrator_soc_init()

[Gustavo A. R. Silva]

Hi Linus,

On 08/02/2017 06:58 AM, Linus Walleij wrote:
> On Thu, Jul 20, 2017 at 12:39 AM, Gustavo A. R. Silva
> <gustavo@embeddedor.com> wrote:
>
>> Remove unnecessary static on local variable syscon_regmap.
>> Such variables are initialized before being used, on every
>> execution path throughout the functions. So, the static has
>> no benefit.
>>
>> This issue was detected using Coccinelle and the following
>> semantic patch:
>>
>> @bad exists@
>> position p;
>> identifier x;
>> type T;
>> @@
>>
>> static T x@p;
>> ...
>> x = <+...x...+>
>>
>> @@
>> identifier x;
>> expression e;
>> type T;
>> position p != bad.p;
>> @@
>>
>> -static
>>  T x@p;
>>  ... when != x
>>      when strict
>> ?x = e;
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> You probably want to funnel this patch through the ARM SoC tree.
>

I'll do that. I'll add your ACK and CC you.

Thanks
-- 
Gustavo A. R. Silva