From: Okash Khawaja <okash.khawaja@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org
Cc: William Hubbs <w.d.hubbs@gmail.com>,
Chris Brannon <chris@the-brannons.com>,
Kirk Reiser <kirk@reisers.ca>,
speakup@linux-speakup.org, devel@driverdev.osuosl.org,
Okash Khawaja <okash.khawaja@gmail.com>
Subject: [patch v3 2/3] staging: speakup: use tty_kopen and tty_kclose
Date: Thu, 20 Jul 2017 08:22:37 +0100 [thread overview]
Message-ID: <20170720072922.883699761@gmail.com> (raw)
In-Reply-To: 20170720072235.186761910@gmail.com
[-- Attachment #1: 20_use_tty_kopen --]
[-- Type: text/plain, Size: 810 bytes --]
This patch replaces call to tty_open_by_driver with a tty_kopen and
uses tty_kclose instead of tty_release_struct to close it.
Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
---
drivers/staging/speakup/spk_ttyio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/staging/speakup/spk_ttyio.c
+++ b/drivers/staging/speakup/spk_ttyio.c
@@ -158,7 +158,7 @@ static int spk_ttyio_initialise_ldisc(st
if (ret)
return ret;
- tty = tty_open_by_driver(dev, NULL, NULL);
+ tty = tty_kopen(dev);
if (IS_ERR(tty))
return PTR_ERR(tty);
@@ -308,7 +308,7 @@ void spk_ttyio_release(void)
tty_ldisc_flush(speakup_tty);
tty_unlock(speakup_tty);
- tty_release_struct(speakup_tty, speakup_tty->index);
+ tty_kclose(speakup_tty);
}
EXPORT_SYMBOL_GPL(spk_ttyio_release);
next prev parent reply other threads:[~2017-07-20 7:29 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 20:28 tty contention resulting from tty_open_by_device export Okash Khawaja
2017-07-08 8:38 ` Greg Kroah-Hartman
2017-07-08 9:01 ` Okash Khawaja
2017-07-09 11:41 ` [patch 0/3] " Okash Khawaja
2017-07-09 11:41 ` [patch 1/3] tty: resolve tty contention between kernel and user space Okash Khawaja
2017-07-09 11:51 ` Greg Kroah-Hartman
2017-07-09 15:04 ` Andy Shevchenko
2017-07-09 19:08 ` Okash Khawaja
2017-07-10 8:31 ` Okash Khawaja
2017-07-10 15:21 ` Andy Shevchenko
2017-07-10 16:12 ` Okash Khawaja
2017-07-09 11:41 ` [patch 2/3] staging: speakup: use tty_kopen instead of tty_open_by_driver Okash Khawaja
2017-07-09 11:50 ` Greg Kroah-Hartman
2017-07-09 12:28 ` Okash Khawaja
2017-07-09 11:41 ` [patch 3/3] tty: undo export " Okash Khawaja
2017-07-09 11:57 ` [patch 0/3] Re: tty contention resulting from tty_open_by_device export Greg Kroah-Hartman
2017-07-09 12:32 ` [patch 4/3] tty: make tty_kopen return ENODEV in case of no TTY Okash Khawaja
2017-07-10 11:52 ` [patch 0/3] Re: tty contention resulting from tty_open_by_device export Alan Cox
2017-07-10 12:33 ` Okash Khawaja
2017-07-10 16:22 ` Okash Khawaja
2017-07-12 18:20 ` Alan Cox
2017-07-13 11:29 ` Okash Khawaja
2017-07-17 12:31 ` Greg Kroah-Hartman
2017-07-17 13:23 ` Okash Khawaja
2017-07-17 22:04 ` Alan Cox
2017-07-18 11:29 ` Okash Khawaja
2017-07-18 12:26 ` Dan Carpenter
2017-07-18 19:22 ` Okash Khawaja
2017-07-18 13:49 ` Alan Cox
2017-07-20 7:22 ` [patch v3 0/3] tty contention resulting from tty_open_by_driver export Okash Khawaja
2017-07-20 7:22 ` [patch v3 1/3] tty: resolve tty contention between kernel and user space Okash Khawaja
2017-07-20 7:22 ` Okash Khawaja [this message]
2017-07-20 7:22 ` [patch v3 3/3] tty: undo export of tty_open_by_driver Okash Khawaja
2017-07-17 21:04 ` [patch v2 0/3] tty contention resulting from tty_open_by_driver export Okash Khawaja
2017-07-17 21:04 ` [patch v2 1/3] tty: resolve tty contention between kernel and user space Okash Khawaja
2017-07-17 21:04 ` [patch v2 2/3] staging: speakup: use tty_kopen instead of tty_open_by_driver Okash Khawaja
2017-07-17 21:04 ` [patch v2 3/3] tty: undo export " Okash Khawaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720072922.883699761@gmail.com \
--to=okash.khawaja@gmail.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).