From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934850AbdGTQXe (ORCPT <rfc822;w@1wt.eu>);
        Thu, 20 Jul 2017 12:23:34 -0400
Received: from mail-wm0-f52.google.com ([74.125.82.52]:36087 "EHLO
        mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934374AbdGTQXd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 20 Jul 2017 12:23:33 -0400
Date: Thu, 20 Jul 2017 18:23:30 +0200
From: Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: Darren Hart <dvhart@infradead.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Mario Limonciello <mario_limonciello@dell.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>, lkp@01.org,
        kernel test robot <xiaolong.ye@intel.com>
Subject: Re: [lkp-robot] [platform/x86]  bff589be59:
 kmsg.dell_wmi:Cannot_read_Dell_descriptor_buffer
Message-ID: <20170720162330.GN16493@pali>
References: <20170720010220.GF27396@yexl-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20170720010220.GF27396@yexl-desktop>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday 20 July 2017 09:02:20 kernel test robot wrote:
> commit: bff589be59c50924a9715951160578e570cba5c6 ("platform/x86: dell-wmi: Convert to the WMI bus infrastructure")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> 
> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
> 
> [    7.104086] dell_wmi: Cannot read Dell descriptor buffer - 1

Hi Andy! Problem is in following code:

static int __init dell_wmi_init(void)
{
	int err;

	err = dell_wmi_check_descriptor_buffer();
	if (err)
		return err;

	dmi_check_system(dell_wmi_smbios_list);

	if (wmi_requires_smbios_request) {
		err = dell_wmi_events_set_enabled(true);
		if (err) {
			pr_err("Failed to enable WMI events\n");
			return err;
		}
	}

	return wmi_driver_register(&dell_wmi_driver);
}
module_init(dell_wmi_init);

static void __exit dell_wmi_exit(void)
{
	if (wmi_requires_smbios_request)
		dell_wmi_events_set_enabled(false);

	wmi_driver_unregister(&dell_wmi_driver);
}
module_exit(dell_wmi_exit);

dell_wmi_init and dell_wmi_exit should just call wmi_driver_register and
wmi_driver_unregister.

All those other calls (like different checks or enabling wmi events)
should be done in dell_wmi_probe from dell_wmi_driver structure. Same
for dell_wmi_remove.

Basically with this bus interface you should be able to load dell-wmi.ko
also on non-dell machines. Just bus code would not create and register
wmi device and so no probe would be called.

-- 
Pali Rohár
pali.rohar@gmail.com