* [lkp-robot] [platform/x86] bff589be59: kmsg.dell_wmi:Cannot_read_Dell_descriptor_buffer
@ 2017-07-20 1:02 kernel test robot
2017-07-20 16:23 ` Pali Rohár
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2017-07-20 1:02 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Darren Hart, Andy Lutomirski, Mario Limonciello, Pali Rohár,
Rafael J. Wysocki, LKML, Linus Torvalds, lkp
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
FYI, we noticed the following commit:
commit: bff589be59c50924a9715951160578e570cba5c6 ("platform/x86: dell-wmi: Convert to the WMI bus infrastructure")
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
in testcase: boot
on test machine: qemu-system-x86_64 -enable-kvm -m 420M
caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
[ 7.102869] usbhid: USB HID core driver
[ 7.104086] dell_wmi: Cannot read Dell descriptor buffer - 1
[ 7.104088] acer_wmi: Acer Laptop ACPI-WMI Extras
[ 7.104097] acer_wmi: No or unsupported WMI interface, unable to load
To reproduce:
git clone https://github.com/01org/lkp-tests.git
cd lkp-tests
bin/lkp qemu -k <bzImage> job-script # job-script is attached in this email
Thanks,
Xiaolong
[-- Attachment #2: job-script --]
[-- Type: text/plain, Size: 3954 bytes --]
#!/bin/sh
export_top_env()
{
export suite='boot'
export testcase='boot'
export timeout='10m'
export job_origin='/lkp/lkp/src/jobs/boot.yaml'
export queue='bisect'
export testbox='vm-lkp-nhm-dp1-openwrt-ia32-4'
export tbox_group='vm-lkp-nhm-dp1-openwrt-ia32'
export branch='linus/master'
export commit='bff589be59c50924a9715951160578e570cba5c6'
export kconfig='x86_64-nfsroot'
export submit_id='596aafb30b9a931af7e8ffa1'
export job_file='/lkp/scheduled/vm-lkp-nhm-dp1-openwrt-ia32-4/boot-1-openwrt-i386-2016-03-16.cgz-bff589be59c50924a9715951160578e570cba5c6-20170716-72439-120txhp-0.yaml'
export id='fac0bb4dbf48ec7df35e4ad4d85535a177303e1b'
export model='qemu-system-x86_64 -enable-kvm'
export nr_vm=10
export nr_cpu=1
export memory='420M'
export rootfs='openwrt-i386-2016-03-16.cgz'
export need_kconfig='CONFIG_KVM_GUEST=y'
export compiler='gcc-6'
export enqueue_time='2017-07-16 08:13:39 +0800'
export _id='596aafb30b9a931af7e8ffa1'
export _rt='/result/boot/1/vm-lkp-nhm-dp1-openwrt-ia32/openwrt-i386-2016-03-16.cgz/x86_64-nfsroot/gcc-6/bff589be59c50924a9715951160578e570cba5c6'
export user='lkp'
export result_root='/result/boot/1/vm-lkp-nhm-dp1-openwrt-ia32/openwrt-i386-2016-03-16.cgz/x86_64-nfsroot/gcc-6/bff589be59c50924a9715951160578e570cba5c6/0'
export LKP_SERVER='inn'
export max_uptime=600
export initrd='/osimage/openwrt/openwrt-i386-2016-03-16.cgz'
export bootloader_append='root=/dev/ram0
user=lkp
job=/lkp/scheduled/vm-lkp-nhm-dp1-openwrt-ia32-4/boot-1-openwrt-i386-2016-03-16.cgz-bff589be59c50924a9715951160578e570cba5c6-20170716-72439-120txhp-0.yaml
ARCH=x86_64
kconfig=x86_64-nfsroot
branch=linus/master
commit=bff589be59c50924a9715951160578e570cba5c6
BOOT_IMAGE=/pkg/linux/x86_64-nfsroot/gcc-6/bff589be59c50924a9715951160578e570cba5c6/vmlinuz-4.12.0-rc1-00039-gbff589b
max_uptime=600
RESULT_ROOT=/result/boot/1/vm-lkp-nhm-dp1-openwrt-ia32/openwrt-i386-2016-03-16.cgz/x86_64-nfsroot/gcc-6/bff589be59c50924a9715951160578e570cba5c6/0
LKP_SERVER=inn
debug
apic=debug
sysrq_always_enabled
rcupdate.rcu_cpu_stall_timeout=100
net.ifnames=0
printk.devkmsg=on
panic=-1
softlockup_panic=1
nmi_watchdog=panic
oops=panic
load_ramdisk=2
prompt_ramdisk=0
drbd.minor_count=8
systemd.log_level=err
ignore_loglevel
earlyprintk=ttyS0,115200
console=ttyS0,115200
console=tty0
vga=normal
rw'
export lkp_initrd='/lkp/lkp/lkp-i386.cgz'
export modules_initrd='/pkg/linux/x86_64-nfsroot/gcc-6/bff589be59c50924a9715951160578e570cba5c6/modules.cgz'
export site='inn'
export LKP_CGI_PORT=80
export LKP_CIFS_PORT=139
export kernel='/pkg/linux/x86_64-nfsroot/gcc-6/bff589be59c50924a9715951160578e570cba5c6/vmlinuz-4.12.0-rc1-00039-gbff589b'
export dequeue_time='2017-07-16 08:18:40 +0800'
export job_initrd='/lkp/scheduled/vm-lkp-nhm-dp1-openwrt-ia32-4/boot-1-openwrt-i386-2016-03-16.cgz-bff589be59c50924a9715951160578e570cba5c6-20170716-72439-120txhp-0.cgz'
[ -n "$LKP_SRC" ] ||
export LKP_SRC=/lkp/${user:-lkp}/src
}
run_job()
{
echo $$ > $TMP/run-job.pid
. $LKP_SRC/lib/http.sh
. $LKP_SRC/lib/job.sh
. $LKP_SRC/lib/env.sh
export_top_env
run_monitor $LKP_SRC/monitors/one-shot/wrapper boot-slabinfo
run_monitor $LKP_SRC/monitors/one-shot/wrapper boot-meminfo
run_monitor $LKP_SRC/monitors/one-shot/wrapper memmap
run_monitor $LKP_SRC/monitors/wrapper kmsg
run_monitor $LKP_SRC/monitors/wrapper oom-killer
run_monitor $LKP_SRC/monitors/plain/watchdog
run_monitor $LKP_SRC/monitors/wrapper nfs-hang
run_test $LKP_SRC/tests/wrapper sleep 1
}
extract_stats()
{
$LKP_SRC/stats/wrapper boot-slabinfo
$LKP_SRC/stats/wrapper boot-meminfo
$LKP_SRC/stats/wrapper memmap
$LKP_SRC/stats/wrapper boot-memory
$LKP_SRC/stats/wrapper boot-time
$LKP_SRC/stats/wrapper kernel-size
$LKP_SRC/stats/wrapper kmsg
$LKP_SRC/stats/wrapper time sleep.time
$LKP_SRC/stats/wrapper time
$LKP_SRC/stats/wrapper dmesg
$LKP_SRC/stats/wrapper kmsg
$LKP_SRC/stats/wrapper stderr
$LKP_SRC/stats/wrapper last_state
}
"$@"
[-- Attachment #3: dmesg.xz --]
[-- Type: application/octet-stream, Size: 13700 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [lkp-robot] [platform/x86] bff589be59: kmsg.dell_wmi:Cannot_read_Dell_descriptor_buffer
2017-07-20 1:02 [lkp-robot] [platform/x86] bff589be59: kmsg.dell_wmi:Cannot_read_Dell_descriptor_buffer kernel test robot
@ 2017-07-20 16:23 ` Pali Rohár
2017-07-20 18:36 ` Andy Lutomirski
0 siblings, 1 reply; 3+ messages in thread
From: Pali Rohár @ 2017-07-20 16:23 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Darren Hart, Andy Lutomirski, Mario Limonciello,
Rafael J. Wysocki, LKML, Linus Torvalds, lkp, kernel test robot
On Thursday 20 July 2017 09:02:20 kernel test robot wrote:
> commit: bff589be59c50924a9715951160578e570cba5c6 ("platform/x86: dell-wmi: Convert to the WMI bus infrastructure")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>
> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
>
> [ 7.104086] dell_wmi: Cannot read Dell descriptor buffer - 1
Hi Andy! Problem is in following code:
static int __init dell_wmi_init(void)
{
int err;
err = dell_wmi_check_descriptor_buffer();
if (err)
return err;
dmi_check_system(dell_wmi_smbios_list);
if (wmi_requires_smbios_request) {
err = dell_wmi_events_set_enabled(true);
if (err) {
pr_err("Failed to enable WMI events\n");
return err;
}
}
return wmi_driver_register(&dell_wmi_driver);
}
module_init(dell_wmi_init);
static void __exit dell_wmi_exit(void)
{
if (wmi_requires_smbios_request)
dell_wmi_events_set_enabled(false);
wmi_driver_unregister(&dell_wmi_driver);
}
module_exit(dell_wmi_exit);
dell_wmi_init and dell_wmi_exit should just call wmi_driver_register and
wmi_driver_unregister.
All those other calls (like different checks or enabling wmi events)
should be done in dell_wmi_probe from dell_wmi_driver structure. Same
for dell_wmi_remove.
Basically with this bus interface you should be able to load dell-wmi.ko
also on non-dell machines. Just bus code would not create and register
wmi device and so no probe would be called.
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [lkp-robot] [platform/x86] bff589be59: kmsg.dell_wmi:Cannot_read_Dell_descriptor_buffer
2017-07-20 16:23 ` Pali Rohár
@ 2017-07-20 18:36 ` Andy Lutomirski
0 siblings, 0 replies; 3+ messages in thread
From: Andy Lutomirski @ 2017-07-20 18:36 UTC (permalink / raw)
To: Pali Rohár
Cc: Andy Lutomirski, Darren Hart, Mario Limonciello,
Rafael J. Wysocki, LKML, Linus Torvalds, LKP, kernel test robot
On Thu, Jul 20, 2017 at 9:23 AM, Pali Rohár <pali.rohar@gmail.com> wrote:
> On Thursday 20 July 2017 09:02:20 kernel test robot wrote:
>> commit: bff589be59c50924a9715951160578e570cba5c6 ("platform/x86: dell-wmi: Convert to the WMI bus infrastructure")
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>>
>> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
>>
>> [ 7.104086] dell_wmi: Cannot read Dell descriptor buffer - 1
>
> Hi Andy! Problem is in following code:
>
> static int __init dell_wmi_init(void)
> {
> int err;
>
> err = dell_wmi_check_descriptor_buffer();
> if (err)
> return err;
>
> dmi_check_system(dell_wmi_smbios_list);
>
> if (wmi_requires_smbios_request) {
> err = dell_wmi_events_set_enabled(true);
> if (err) {
> pr_err("Failed to enable WMI events\n");
> return err;
> }
> }
>
> return wmi_driver_register(&dell_wmi_driver);
> }
> module_init(dell_wmi_init);
>
> static void __exit dell_wmi_exit(void)
> {
> if (wmi_requires_smbios_request)
> dell_wmi_events_set_enabled(false);
>
> wmi_driver_unregister(&dell_wmi_driver);
> }
> module_exit(dell_wmi_exit);
>
> dell_wmi_init and dell_wmi_exit should just call wmi_driver_register and
> wmi_driver_unregister.
>
> All those other calls (like different checks or enabling wmi events)
> should be done in dell_wmi_probe from dell_wmi_driver structure. Same
> for dell_wmi_remove.
>
> Basically with this bus interface you should be able to load dell-wmi.ko
> also on non-dell machines. Just bus code would not create and register
> wmi device and so no probe would be called.
Yep. Fix coming once I test it.
>
> --
> Pali Rohár
> pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-20 18:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-20 1:02 [lkp-robot] [platform/x86] bff589be59: kmsg.dell_wmi:Cannot_read_Dell_descriptor_buffer kernel test robot
2017-07-20 16:23 ` Pali Rohár
2017-07-20 18:36 ` Andy Lutomirski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox