From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752094AbdGUGaj (ORCPT ); Fri, 21 Jul 2017 02:30:39 -0400 Received: from mga04.intel.com ([192.55.52.120]:57264 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925AbdGUGai (ORCPT ); Fri, 21 Jul 2017 02:30:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,388,1496127600"; d="scan'208";a="113812614" Date: Fri, 21 Jul 2017 12:03:26 +0530 From: Vinod Koul To: Greg KH Cc: Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] DMA: ppc4xx: remove DRIVER_ATTR() usage Message-ID: <20170721063326.GL3053@localhost> References: <20170719125628.GC17776@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170719125628.GC17776@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 19, 2017 at 02:56:28PM +0200, Greg KH wrote: > From: Greg Kroah-Hartman > > It's better to be explicit and use the DRIVER_ATTR_RW() and > DRIVER_ATTR_RO() macros when defining a driver's sysfs file. > > Bonus is this fixes up a checkpatch.pl warning. Applied after fixing the subsystem name, thanks -- ~Vinod