From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756016AbdGXN2k (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Jul 2017 09:28:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40034 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754706AbdGXN2d (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Jul 2017 09:28:33 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D513F336F04
Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D513F336F04
Date: Mon, 24 Jul 2017 15:28:28 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Arun Kalyanasundaram <arunkaly@google.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>,
        "David S . Miller" <davem@davemloft.net>,
        SeongJae Park <sj38.park@gmail.com>, davidcc@google.com,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v2 0/5] perf script python: Provide sample dict to all
 handlers
Message-ID: <20170724132828.GA30848@krava>
References: <20170721220422.63962-1-arunkaly@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170721220422.63962-1-arunkaly@google.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 24 Jul 2017 13:28:33 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 21, 2017 at 03:04:17PM -0700, Arun Kalyanasundaram wrote:
> v2: - Add sample_read struct to the dict (in 3/5).
>     - Increase reference count of callchain in process tracepoint to
>       avoid unnecessary garbage collection (in 4/5).
> 
> The process_event python hook receives a dict with most perf_sample entries.
> 
> Other handlers (e.g. trace_unhandled, python_process_tracepoint) predate the introduction of this dict and do not receive it. This patch series adds the dict to all handlers, aiming to unify the information passed to them.
> 
> This change adds an additional argument to the affected handlers. To keep backwards compatibility (and avoid unnecessary work), do not pass the aforementioned dict if the number of arguments signals that handler version predates this change.
> 
> In addition, provide time_enabled, time_running and counter value in the perf_sample dict.
> 
> Initial Discussion: https://lkml.org/lkml/2017/7/1/108
> 
> Arun Kalyanasundaram (5):
>   perf script python: Allocate memory only if handler exists
>   perf script python: Refactor creation of perf sample dict
>   perf script python: Add sample_read to dict
>   perf script python: Add perf_sample dict to tracepoint handlers
>   perf script python: Generate hooks with additional argument
> 

looks good,

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka