From: Matt Fleming <matt@codeblueprint.co.uk>
To: Baoquan He <bhe@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, x86@kernel.org,
keescook@chromium.org, tglx@linutronix.de, hpa@zytor.com,
izumi.taku@jp.fujitsu.com, fanc.fnst@cn.fujitsu.com,
thgarnie@google.com, n-horiguchi@ah.jp.nec.com
Subject: Re: [PATCH v6 RESEND] x86/boot/KASLR: Restrict kernel to be randomized in mirror regions
Date: Mon, 24 Jul 2017 14:34:10 +0100 [thread overview]
Message-ID: <20170724133410.GC11076@codeblueprint.co.uk> (raw)
In-Reply-To: <20170721131956.GK2344@x1>
On Fri, 21 Jul, at 09:19:56PM, Baoquan He wrote:
>
> There are places where the efi map is getting and used like this. E.g
> in efi_high_alloc() of drivers/firmware/efi/libstub/efi-stub-helper.c.
> EFI developers worry the size of efi_memory_desc_t could not be the same
> as e->efi_memdesc_size?
>
> Hi Matt,
>
> Could you help have a look at this?
You're exactly right. The code guards against the size of the
efi_memory_desc_t struct changing. The UEFI spec says to traverse the
memory map this way.
next prev parent reply other threads:[~2017-07-24 13:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 9:16 [PATCH v6 RESEND] x86/boot/KASLR: Restrict kernel to be randomized in mirror regions Baoquan He
2017-07-21 10:33 ` Ingo Molnar
2017-07-21 12:35 ` Baoquan He
2017-07-21 10:37 ` Ingo Molnar
2017-07-21 13:19 ` Baoquan He
2017-07-21 17:37 ` Ingo Molnar
2017-07-21 23:43 ` Baoquan He
2017-07-24 13:34 ` Matt Fleming [this message]
2017-07-25 0:23 ` Baoquan He
2017-07-28 8:06 ` Baoquan He
2017-07-28 9:55 ` Ingo Molnar
2017-07-28 10:18 ` Baoquan He
2017-07-28 10:38 ` Baoquan He
2017-07-28 11:26 ` Baoquan He
2017-08-04 11:23 ` Matt Fleming
2017-08-04 11:40 ` Baoquan He
2017-08-04 11:55 ` Matt Fleming
2017-08-04 12:02 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170724133410.GC11076@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=bhe@redhat.com \
--cc=fanc.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox