From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932203AbdGXOQ6 (ORCPT ); Mon, 24 Jul 2017 10:16:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33902 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370AbdGXOQw (ORCPT ); Mon, 24 Jul 2017 10:16:52 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7DD06356D6 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7DD06356D6 Date: Mon, 24 Jul 2017 16:16:49 +0200 From: Jiri Olsa To: Sukadev Bhattiprolu Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools: Make build fail on JSON parse error Message-ID: <20170724141649.GA2645@krava> References: <20170721192557.4371-1-andi@firstfloor.org> <20170722003159.GA15787@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170722003159.GA15787@us.ibm.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 24 Jul 2017 14:16:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 21, 2017 at 05:31:59PM -0700, Sukadev Bhattiprolu wrote: > Andi Kleen [andi@firstfloor.org] wrote: > > From: Andi Kleen > > > > Today, when a JSON file fails parsing the build continues, > > but there are no json files built in, which is difficult to debug later. > > Make the build stop on a parse error instead. > > I see the problem and we were being defensive to not break the build > on architectures that don't yet have the PMU event lists. It will be > good to check build on an architecture other than x86/powerpc. > > Also, following comments may no longer be applicable? Isn't the Andi's change only to fail in case there's a real error in process_one_file? I think you can still have empty events dir. jirka