From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932099AbdGXRql (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Jul 2017 13:46:41 -0400
Received: from one.firstfloor.org ([193.170.194.197]:34728 "EHLO
        one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755859AbdGXRo4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Jul 2017 13:44:56 -0400
Date: Mon, 24 Jul 2017 10:44:54 -0700
From: Andi Kleen <andi@firstfloor.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
        Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
        Andi Kleen <andi@firstfloor.org>, jolsa@kernel.org,
        linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools: Make build fail on JSON parse error
Message-ID: <20170724174454.GR3044@two.firstfloor.org>
References: <20170721192557.4371-1-andi@firstfloor.org>
 <20170722003159.GA15787@us.ibm.com>
 <20170724141649.GA2645@krava>
 <20170724174209.GW4134@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170724174209.GW4134@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 24, 2017 at 02:42:09PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jul 24, 2017 at 04:16:49PM +0200, Jiri Olsa escreveu:
> > On Fri, Jul 21, 2017 at 05:31:59PM -0700, Sukadev Bhattiprolu wrote:
> > > Andi Kleen [andi@firstfloor.org] wrote:
> > > > From: Andi Kleen <ak@linux.intel.com>
> > > > 
> > > > Today, when a JSON file fails parsing the build continues,
> > > > but there are no json files built in, which is difficult to debug later.
> > > > Make the build stop on a parse error instead.
> > > 
> > > I see the problem and we were being defensive to not break the build
> > > on architectures that don't yet have the PMU event lists. It will be
> > > good to check build on an architecture other than x86/powerpc.
> > > 
> > > Also, following comments may no longer be applicable?
> > 
> > Isn't the Andi's change only to fail in case there's
> > a real error in process_one_file? I think you can still
> > have empty events dir.
> 
> That explains why all the cross builds failed when I added that cset?

Hmm, let me test. It was supposed to only fail when there
is a file, but it cannot be parsed.

-Andi