From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756520AbdGXTVA (ORCPT ); Mon, 24 Jul 2017 15:21:00 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:34210 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932405AbdGXTUW (ORCPT ); Mon, 24 Jul 2017 15:20:22 -0400 Date: Mon, 24 Jul 2017 21:20:17 +0200 From: Pavel Machek To: Sebastian Reichel Cc: Sebastian Reichel , Dmitry Torokhov , Tony Lindgren , Rob Herring , linux-input@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 1/3] dt-bindings: input: add pwm-vibrator Message-ID: <20170724192017.GE32425@amd> References: <20170714100151.31234-1-sebastian.reichel@collabora.co.uk> <20170714100151.31234-2-sebastian.reichel@collabora.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BZaMRJmqxGScZ8Mx" Content-Disposition: inline In-Reply-To: <20170714100151.31234-2-sebastian.reichel@collabora.co.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --BZaMRJmqxGScZ8Mx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2017-07-14 12:01:49, Sebastian Reichel wrote: > Add DT binding document for PWM controlled vibrator devices. >=20 > Signed-off-by: Sebastian Reichel Acked-by: Pavel Machek > index 000000000000..09145d18491d > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/pwm-vibrator.txt > @@ -0,0 +1,66 @@ > +* PWM vibrator device tree bindings > + > +Registers a PWM device as vibrator. It is expected, that the vibrator's > +strength increases based on the duty cycle of the enable PWM channel > +(100% duty cycle meaning strongest vibration, 0% meaning no vibration). > + > +The binding supports an optional direction PWM channel, that can be > +driven at fixed duty cycle. If available this is can be used to increase > +the vibration effect of some devices. Actually what "direction" does would be nice to explain, because I don't know. Does it make the motor turn the other way around? > +Required properties: > +- compatible: should contain "pwm-vibrator" should->Should. > +- pwm-names: Should contain "enable" and optionally "direction" > +- pwms: Should contain a PWM handle for each entry in pwm-names > + > +Optional properties: > +- vcc-supply: Phandle for the regulator supplying power > +- direction-duty-cycle-ns: Duty cycle of the direction PWM channel in > + nanoseconds, defaults to 50% of the channel's > + period. Is nanoseconds right unit here? It drives a motor... Thanks, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --BZaMRJmqxGScZ8Mx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAll2SHEACgkQMOfwapXb+vL6eQCgnQ/nkXsG/SRMySTB9qHW4rWu wz8An1IVCctTyOwSxPrUvtsT+MdeqlYa =0UQO -----END PGP SIGNATURE----- --BZaMRJmqxGScZ8Mx--