From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755485AbdGXVlN (ORCPT ); Mon, 24 Jul 2017 17:41:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39924 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753618AbdGXVlG (ORCPT ); Mon, 24 Jul 2017 17:41:06 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 20A776C06 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mst@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 20A776C06 Date: Tue, 25 Jul 2017 00:41:06 +0300 From: "Michael S. Tsirkin" To: David Miller Cc: jasowang@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next V2 0/5] Refine virtio-net XDP Message-ID: <20170725000830-mutt-send-email-mst@kernel.org> References: <1500454489-16805-1-git-send-email-jasowang@redhat.com> <20170724.133859.192337723544942743.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170724.133859.192337723544942743.davem@davemloft.net> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 24 Jul 2017 21:41:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 24, 2017 at 01:38:59PM -0700, David Miller wrote: > From: Jason Wang > Date: Wed, 19 Jul 2017 16:54:44 +0800 > > > Hi: > > > > This series brings two optimizations for virtio-net XDP: > > > > - avoid reset during XDP set > > - turn off offloads on demand > > > > Changes from V1: > > - Various tweaks on commit logs and comments > > - Use virtnet_napi_enable() when enabling NAPI on XDP set > > - Copy the small buffer packet only if xdp_headroom is smaller than > > required > > > > Please review. > > Series applied, thanks Jason. > > Michael, I gave you 4+ days to properly review this respin of this > series. I felt that was more than sufficient time, even with an > intervening weekend. So if you don't like that I applied this without > your review, please be more punctual in the future. > > Thank you. My bad - reviewed when I was offline and forgot to send it out. By luck this is not a big deal: - Patches 1-4 are good. - Patch 5 has some problems IMO, but all it does is try to enable a previously non-working configuration, so it seems ok to fix it up with follow-up patches as appropriate. -- MST