From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>,
sukadev@linux.vnet.ibm.com
Subject: Re: [PATCH] perf, tools: Make build fail on JSON parse error
Date: Tue, 25 Jul 2017 09:26:16 +0200 [thread overview]
Message-ID: <20170725072616.GA8400@krava> (raw)
In-Reply-To: <20170725001638.19990-1-andi@firstfloor.org>
On Mon, Jul 24, 2017 at 05:16:38PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Today, when a JSON file fails parsing the build continues,
> but there are no json files built in, which is difficult to debug later.
> Make the build stop on a parse error instead.
>
> v2: Add fixes from Sukadev. Now we handle architectures
> with no JSON events correctly. And fix some stale comments.
> Cc: sukadev@linux.vnet.ibm.com
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2017-07-25 7:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 0:16 [PATCH] perf, tools: Make build fail on JSON parse error Andi Kleen
2017-07-25 7:26 ` Jiri Olsa [this message]
2017-07-26 17:26 ` [tip:perf/core] perf jevents: " tip-bot for Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2017-07-21 19:25 [PATCH] perf, tools: " Andi Kleen
2017-07-22 0:31 ` Sukadev Bhattiprolu
2017-07-24 14:16 ` Jiri Olsa
2017-07-24 17:42 ` Arnaldo Carvalho de Melo
2017-07-24 17:44 ` Andi Kleen
2017-07-24 19:07 ` Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725072616.GA8400@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox