From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750968AbdGYH0U (ORCPT ); Tue, 25 Jul 2017 03:26:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54036 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbdGYH0T (ORCPT ); Tue, 25 Jul 2017 03:26:19 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3D136461FE Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com Date: Tue, 25 Jul 2017 09:26:16 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen , sukadev@linux.vnet.ibm.com Subject: Re: [PATCH] perf, tools: Make build fail on JSON parse error Message-ID: <20170725072616.GA8400@krava> References: <20170725001638.19990-1-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170725001638.19990-1-andi@firstfloor.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 25 Jul 2017 07:26:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 24, 2017 at 05:16:38PM -0700, Andi Kleen wrote: > From: Andi Kleen > > Today, when a JSON file fails parsing the build continues, > but there are no json files built in, which is difficult to debug later. > Make the build stop on a parse error instead. > > v2: Add fixes from Sukadev. Now we handle architectures > with no JSON events correctly. And fix some stale comments. > Cc: sukadev@linux.vnet.ibm.com > Signed-off-by: Andi Kleen Acked-by: Jiri Olsa thanks, jirka