From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751421AbdGYIzX (ORCPT ); Tue, 25 Jul 2017 04:55:23 -0400 Received: from muru.com ([72.249.23.125]:55690 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793AbdGYIzW (ORCPT ); Tue, 25 Jul 2017 04:55:22 -0400 Date: Tue, 25 Jul 2017 01:55:17 -0700 From: Tony Lindgren To: Johan Hovold Cc: Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Alan Stern , Dave Gerlach , Kevin Hilman , Nishanth Menon , "Rafael J . Wysocki" , Ulf Hansson Subject: Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update from suspend_noirq Message-ID: <20170725085517.GQ10026@atomide.com> References: <20170724095201.21601-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170724095201.21601-1-johan@kernel.org> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Johan Hovold [170724 02:53]: > Since commit a8636c89648a ("PM / Runtime: Don't allow to suspend a > device with an active child"), which went into 4.10, it is no longer > permitted to set RPM_SUSPENDED state for a device with active children > (unless power.ignore_children is set). > > This specifically means that the attempts to do just that from the omap > pm-domain suspend_noirq callback have since been failing whenever a > child is active, for example: > > am335x-usb-childs 47400000.usb: runtime PM trying to suspend > device but active child > > Silence this warning by dropping the broken pm_runtime_set_suspended() > call from the omap suspend_noirq callback along with the redundant > pm_runtime_set_active() in resume_noirq. With this things still work for me for my PM tests on omap3. Device suspends and resumes just fine hitting off mode during suspend. Regards, Tony