From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751451AbdGYKAR (ORCPT ); Tue, 25 Jul 2017 06:00:17 -0400 Received: from mga14.intel.com ([192.55.52.115]:11667 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751325AbdGYKAQ (ORCPT ); Tue, 25 Jul 2017 06:00:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,411,1496127600"; d="scan'208";a="1155109659" Date: Tue, 25 Jul 2017 13:00:12 +0300 From: Mika Westerberg To: "Rafael J. Wysocki" Cc: LKML , Linux PM , Andreas Noever , Michael Jamet , Greg Kroah-Hartman Subject: Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in icm_suspend() Message-ID: <20170725100012.GH2369@lahna.fi.intel.com> References: <4063610.TqANq0McE8@aspire.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4063610.TqANq0McE8@aspire.rjw.lan> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 25, 2017 at 01:31:00AM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > On one of my test machines nhi_mailbox_cmd() called from icm_suspend() > times out and returnes an error which then is propagated to the > caller and causes the entire system suspend to be aborted which isn't > very useful. > > Instead of aborting system suspend, print the error into the log > and continue. I agree, it should not prevent suspend but I wonder why it fails in the first place? Can you check what is the return value?