From: Miroslav Lichvar <mlichvar@redhat.com>
To: Santosh Sivaraj <santosh@fossix.org>
Cc: linux-kernel@vger.kernel.org,
John Stultz <john.stultz@linaro.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Paul Elder <paul.elder@pitt.edu>
Subject: Re: [PATCH] kselftest/timers: fix build failure
Date: Tue, 25 Jul 2017 14:40:19 +0200 [thread overview]
Message-ID: <20170725124019.GC19732@localhost> (raw)
In-Reply-To: <20170725075037.2014-1-santosh@fossix.org>
On Tue, Jul 25, 2017 at 01:20:37PM +0530, Santosh Sivaraj wrote:
> "message" parameter was not passed to ksft_exit_skip.
It looks like this was a bad merge of 76739256 and 54f57baa, which
added the new parameter to ksft_exit_skip().
> @@ -231,7 +231,7 @@ static void init_test(void)
>
> if (precision > MAX_PRECISION) {
> printf("[SKIP]\n");
> - ksft_exit_skip();
> + ksft_exit_skip("[SKIP]\n");
To avoid printing "skip" multiple times, I'd suggest to change the
argument of ksft_exit_skip to NULL.
Thanks,
--
Miroslav Lichvar
next prev parent reply other threads:[~2017-07-25 12:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 7:50 [PATCH] kselftest/timers: fix build failure Santosh Sivaraj
2017-07-25 12:40 ` Miroslav Lichvar [this message]
2017-07-25 13:32 ` [PATCH v2] " Santosh Sivaraj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725124019.GC19732@localhost \
--to=mlichvar@redhat.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paul.elder@pitt.edu \
--cc=santosh@fossix.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox