* [PATCH] kselftest/timers: fix build failure
@ 2017-07-25 7:50 Santosh Sivaraj
2017-07-25 12:40 ` Miroslav Lichvar
0 siblings, 1 reply; 3+ messages in thread
From: Santosh Sivaraj @ 2017-07-25 7:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Miroslav Lichvar, John Stultz, Ingo Molnar, Thomas Gleixner
"message" parameter was not passed to ksft_exit_skip.
Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
---
tools/testing/selftests/timers/freq-step.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/timers/freq-step.c b/tools/testing/selftests/timers/freq-step.c
index e8c6183..bda9744 100644
--- a/tools/testing/selftests/timers/freq-step.c
+++ b/tools/testing/selftests/timers/freq-step.c
@@ -231,7 +231,7 @@ static void init_test(void)
if (precision > MAX_PRECISION) {
printf("[SKIP]\n");
- ksft_exit_skip();
+ ksft_exit_skip("[SKIP]\n");
}
printf("[OK]\n");
--
2.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kselftest/timers: fix build failure
2017-07-25 7:50 [PATCH] kselftest/timers: fix build failure Santosh Sivaraj
@ 2017-07-25 12:40 ` Miroslav Lichvar
2017-07-25 13:32 ` [PATCH v2] " Santosh Sivaraj
0 siblings, 1 reply; 3+ messages in thread
From: Miroslav Lichvar @ 2017-07-25 12:40 UTC (permalink / raw)
To: Santosh Sivaraj
Cc: linux-kernel, John Stultz, Ingo Molnar, Thomas Gleixner,
Paul Elder
On Tue, Jul 25, 2017 at 01:20:37PM +0530, Santosh Sivaraj wrote:
> "message" parameter was not passed to ksft_exit_skip.
It looks like this was a bad merge of 76739256 and 54f57baa, which
added the new parameter to ksft_exit_skip().
> @@ -231,7 +231,7 @@ static void init_test(void)
>
> if (precision > MAX_PRECISION) {
> printf("[SKIP]\n");
> - ksft_exit_skip();
> + ksft_exit_skip("[SKIP]\n");
To avoid printing "skip" multiple times, I'd suggest to change the
argument of ksft_exit_skip to NULL.
Thanks,
--
Miroslav Lichvar
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] kselftest/timers: fix build failure
2017-07-25 12:40 ` Miroslav Lichvar
@ 2017-07-25 13:32 ` Santosh Sivaraj
0 siblings, 0 replies; 3+ messages in thread
From: Santosh Sivaraj @ 2017-07-25 13:32 UTC (permalink / raw)
To: linux-kernel; +Cc: Miroslav Lichvar, John Stultz, Ingo Molnar, Thomas Gleixner
Pass missing parameter to ksft_exit_skip.
Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
---
V2 update: Pass NULL as suggested by Miroslav Lichvar
tools/testing/selftests/timers/freq-step.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/timers/freq-step.c b/tools/testing/selftests/timers/freq-step.c
index e8c6183..deff065 100644
--- a/tools/testing/selftests/timers/freq-step.c
+++ b/tools/testing/selftests/timers/freq-step.c
@@ -231,7 +231,7 @@ static void init_test(void)
if (precision > MAX_PRECISION) {
printf("[SKIP]\n");
- ksft_exit_skip();
+ ksft_exit_skip(NULL);
}
printf("[OK]\n");
--
2.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-25 13:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-25 7:50 [PATCH] kselftest/timers: fix build failure Santosh Sivaraj
2017-07-25 12:40 ` Miroslav Lichvar
2017-07-25 13:32 ` [PATCH v2] " Santosh Sivaraj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox