From: Tejun Heo <tj@kernel.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Alexei Potashnik <alexei@purestorage.com>,
kernel test robot <xiaolong.ye@intel.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
lkp@01.org, kernel-team@fb.com
Subject: Re: [PATCH wq/for-4.13-fixes] workqueue: implicit ordered attribute should be overridable
Date: Tue, 25 Jul 2017 13:29:40 -0400 [thread overview]
Message-ID: <20170725172940.GF3216015@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20170723123615.GD1498614@devbig577.frc2.facebook.com>
On Sun, Jul 23, 2017 at 08:36:15AM -0400, Tejun Heo wrote:
> 5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active==1 to be
> ordered") automatically enabled ordered attribute for unbound
> workqueues w/ max_active == 1. Because ordered workqueues reject
> max_active and some attribute changes, this implicit ordered mode
> broke cases where the user creates an unbound workqueue w/ max_active
> == 1 and later explicitly changes the related attributes.
>
> This patch distinguishes explicit and implicit ordered setting and
> overrides from attribute changes if implict.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Fixes: 5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active==1 to be ordered")
Applied to wq/for-4.13-fixes.
Thanks.
--
tejun
prev parent reply other threads:[~2017-07-25 17:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-22 20:37 [workqueue] 5c0338c687: WARNING:at_kernel/workqueue.c:#workqueue_set_max_active kernel test robot
2017-07-23 12:36 ` [PATCH wq/for-4.13-fixes] workqueue: implicit ordered attribute should be overridable Tejun Heo
2017-07-25 17:29 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725172940.GF3216015@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=alexei@purestorage.com \
--cc=hch@infradead.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=sfr@canb.auug.org.au \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox