From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751687AbdGYR3q (ORCPT ); Tue, 25 Jul 2017 13:29:46 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:33253 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbdGYR3o (ORCPT ); Tue, 25 Jul 2017 13:29:44 -0400 Date: Tue, 25 Jul 2017 13:29:40 -0400 From: Tejun Heo To: LKML Cc: Christoph Hellwig , Alexei Potashnik , kernel test robot , Stephen Rothwell , lkp@01.org, kernel-team@fb.com Subject: Re: [PATCH wq/for-4.13-fixes] workqueue: implicit ordered attribute should be overridable Message-ID: <20170725172940.GF3216015@devbig577.frc2.facebook.com> References: <20170722203725.GA77833@inn.lkp.intel.com> <20170723123615.GD1498614@devbig577.frc2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170723123615.GD1498614@devbig577.frc2.facebook.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 23, 2017 at 08:36:15AM -0400, Tejun Heo wrote: > 5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active==1 to be > ordered") automatically enabled ordered attribute for unbound > workqueues w/ max_active == 1. Because ordered workqueues reject > max_active and some attribute changes, this implicit ordered mode > broke cases where the user creates an unbound workqueue w/ max_active > == 1 and later explicitly changes the related attributes. > > This patch distinguishes explicit and implicit ordered setting and > overrides from attribute changes if implict. > > Signed-off-by: Tejun Heo > Fixes: 5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active==1 to be ordered") Applied to wq/for-4.13-fixes. Thanks. -- tejun