From: Stephen Boyd <sboyd@codeaurora.org>
To: linux-sparse@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Sparse warnings on GENMASK + arm32
Date: Tue, 25 Jul 2017 18:30:20 -0700 [thread overview]
Message-ID: <20170726013020.GL2146@codeaurora.org> (raw)
I see sparse warning when I check a clk driver file in the kernel
on a 32-bit ARM build.
drivers/clk/sunxi/clk-sun6i-ar100.c:65:20: warning: cast truncates bits from constant value (3ffffffff becomes ffffffff)
The code in question looks like:
static const struct factors_data sun6i_ar100_data = {
.mux = 16,
.muxmask = GENMASK(1, 0),
.table = &sun6i_ar100_config,
.getter = sun6i_get_ar100_factors,
};
where factors_data is
struct factors_data {
int enable;
int mux;
int muxmask;
const struct clk_factors_config *table;
void (*getter)(struct factors_request *req);
void (*recalc)(struct factors_request *req);
const char *name;
};
and sparse seems to be complaining about the muxmask assignment
here. Oddly, this doesn't happen on arm64 builds. Both times, I'm
checking this on an x86-64 machine.
$ sparse --version
v0.5.1-rc4-1-gfa71b7ac0594
Is there something confusing to sparse in the GENMASK macro?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next reply other threads:[~2017-07-26 1:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 1:30 Stephen Boyd [this message]
2017-07-26 13:33 ` Sparse warnings on GENMASK + arm32 Lance Richardson
2017-07-26 13:46 ` Luc Van Oostenryck
2017-07-26 13:47 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170726013020.GL2146@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox