From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751761AbdGZIhJ (ORCPT <rfc822;w@1wt.eu>);
        Wed, 26 Jul 2017 04:37:09 -0400
Received: from mga04.intel.com ([192.55.52.120]:48778 "EHLO mga04.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751150AbdGZIhI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 26 Jul 2017 04:37:08 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,414,1496127600"; 
   d="scan'208";a="997323517"
Date: Wed, 26 Jul 2017 11:32:44 +0300
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in
 icm_suspend()
Message-ID: <20170726083244.GE2369@lahna.fi.intel.com>
References: <4063610.TqANq0McE8@aspire.rjw.lan>
 <20170725100012.GH2369@lahna.fi.intel.com>
 <2537138.AhdhMFtmoG@aspire.rjw.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2537138.AhdhMFtmoG@aspire.rjw.lan>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 25, 2017 at 06:10:57PM +0200, Rafael J. Wysocki wrote:
> On Tuesday, July 25, 2017 01:00:12 PM Mika Westerberg wrote:
> > On Tue, Jul 25, 2017 at 01:31:00AM +0200, Rafael J. Wysocki wrote:
> > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > > 
> > > On one of my test machines nhi_mailbox_cmd() called from icm_suspend()
> > > times out and returnes an error which then is propagated to the
> > > caller and causes the entire system suspend to be aborted which isn't
> > > very useful.
> > > 
> > > Instead of aborting system suspend, print the error into the log
> > > and continue.
> > 
> > I agree, it should not prevent suspend but I wonder why it fails in the
> > first place? Can you check what is the return value?
> 
> As per the above, the error is a timeout, ie. -ETIMEDOUT.

Ah, right I somehow missed that.

Does it have Falcon Ridge controller or Alpine Ridge? Just to make sure,
can you increase the timeout in nhi_mailbox_cmd() to 1000ms or so. It
should not take that long though but better to check.

Which system this is BTW?