From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751794AbdGZMDH (ORCPT ); Wed, 26 Jul 2017 08:03:07 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:59900 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751619AbdGZMC1 (ORCPT ); Wed, 26 Jul 2017 08:02:27 -0400 Date: Wed, 26 Jul 2017 13:02:33 +0100 From: Will Deacon To: Rob Herring Cc: Catalin Marinas , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , luc.vanoostenryck@gmail.com, dan.carpenter@oracle.com Subject: Re: [PATCH] arm64: Convert to using %pOF instead of full_name Message-ID: <20170726120233.GC2115@arm.com> References: <20170718214339.7774-2-robh@kernel.org> <20170725120422.GD27768@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On Tue, Jul 25, 2017 at 07:27:29PM -0500, Rob Herring wrote: > On Tue, Jul 25, 2017 at 7:04 AM, Will Deacon wrote: > > On Tue, Jul 18, 2017 at 04:42:42PM -0500, Rob Herring wrote: > >> Now that we have a custom printf format specifier, convert users of > >> full_name to use %pOF instead. This is preparation to remove storing > >> of the full path string for each node. > >> > >> Signed-off-by: Rob Herring > >> Cc: Catalin Marinas > >> Cc: Will Deacon > >> Cc: linux-arm-kernel@lists.infradead.org > >> --- > >> arch/arm64/kernel/cpu_ops.c | 4 ++-- > >> arch/arm64/kernel/smp.c | 12 ++++++------ > >> arch/arm64/kernel/topology.c | 22 +++++++++++----------- > >> 3 files changed, 19 insertions(+), 19 deletions(-) > > > > I've queued this and the perf patch too, but it would be good if somebody > > could update sparse to recognise this format specifier. Currently it > > just complains about it. > > I'm happy to fix it, but I ran sparse and don't see any errors. Got a pointer? I went back and checked again and it's not sparse that's warning, it's actually smatch (sorry for getting that mixed up): arch/arm64/kernel/cpu_ops.c:85 cpu_read_enable_method() error: unrecognized %p extension 'O', treated as normal %p [smatch] Will