From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751637AbdG0SWz (ORCPT ); Thu, 27 Jul 2017 14:22:55 -0400 Received: from smtprelay0011.hostedemail.com ([216.40.44.11]:52746 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751313AbdG0SWy (ORCPT ); Thu, 27 Jul 2017 14:22:54 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1434:1437:1515:1516:1518:1535:1543:1593:1594:1711:1730:1747:1777:1792:1801:2393:2553:2559:2562:2897:3138:3139:3140:3141:3142:3165:3355:3622:3865:3868:3870:3871:4321:4605:5007:6261:6742:7514:7688:7875:7903:8957:10004:10400:10848:10967:11026:11232:11473:11657:11658:11914:12043:12114:12291:12295:12296:12438:12555:12683:12740:12760:12895:12986:13439:13846:14096:14097:14181:14659:14721:21080:21451:21627:30046:30054:30075:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: dust11_70204a4b00d61 X-Filterd-Recvd-Size: 5061 Date: Thu, 27 Jul 2017 14:22:45 -0400 From: Steven Rostedt To: Vitaly Kuznetsov Cc: devel@linuxdriverproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Jork Loeser , Simon Xiao , Andy Lutomirski , Andy Shevchenko Subject: Re: [PATCH v9 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() Message-ID: <20170727142245.2db4fdde@vmware.local.home> In-Reply-To: <20170714124442.22025-11-vkuznets@redhat.com> References: <20170714124442.22025-1-vkuznets@redhat.com> <20170714124442.22025-11-vkuznets@redhat.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Jul 2017 14:44:42 +0200 Vitaly Kuznetsov wrote: > Add Hyper-V tracing subsystem and trace hyperv_mmu_flush_tlb_others(). > Tracing is done the same way we do xen_mmu_flush_tlb_others(). > > Signed-off-by: Vitaly Kuznetsov > Reviewed-by: Andy Shevchenko > Reviewed-by: Stephen Hemminger Reviewed-by: Steven Rostedt (VMware) (comment below) > --- > MAINTAINERS | 1 + > arch/x86/hyperv/mmu.c | 7 +++++++ > arch/x86/include/asm/trace/hyperv.h | 40 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 48 insertions(+) > create mode 100644 arch/x86/include/asm/trace/hyperv.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index d8eab9322ba2..4a491f3b8cfd 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6276,6 +6276,7 @@ M: Stephen Hemminger > L: devel@linuxdriverproject.org > S: Maintained > F: arch/x86/include/asm/mshyperv.h > +F: arch/x86/include/asm/trace/hyperv.h > F: arch/x86/include/uapi/asm/hyperv.h > F: arch/x86/kernel/cpu/mshyperv.c > F: arch/x86/hyperv > diff --git a/arch/x86/hyperv/mmu.c b/arch/x86/hyperv/mmu.c > index 6fb84c4c3ee7..41bff87fb055 100644 > --- a/arch/x86/hyperv/mmu.c > +++ b/arch/x86/hyperv/mmu.c > @@ -8,6 +8,9 @@ > #include > #include > > +#define CREATE_TRACE_POINTS > +#include > + > /* HvFlushVirtualAddressSpace, HvFlushVirtualAddressList hypercalls */ > struct hv_flush_pcpu { > u64 address_space; > @@ -101,6 +104,8 @@ static void hyperv_flush_tlb_others(const struct cpumask *cpus, > u64 status = U64_MAX; > unsigned long flags; > > + trace_hyperv_mmu_flush_tlb_others(cpus, info); > + > if (!pcpu_flush || !hv_hypercall_pg) > goto do_native; > > @@ -170,6 +175,8 @@ static void hyperv_flush_tlb_others_ex(const struct cpumask *cpus, > u64 status = U64_MAX; > unsigned long flags; > > + trace_hyperv_mmu_flush_tlb_others(cpus, info); > + > if (!pcpu_flush_ex || !hv_hypercall_pg) > goto do_native; > > diff --git a/arch/x86/include/asm/trace/hyperv.h b/arch/x86/include/asm/trace/hyperv.h > new file mode 100644 > index 000000000000..4253bca99989 > --- /dev/null > +++ b/arch/x86/include/asm/trace/hyperv.h > @@ -0,0 +1,40 @@ > +#undef TRACE_SYSTEM > +#define TRACE_SYSTEM hyperv > + > +#if !defined(_TRACE_HYPERV_H) || defined(TRACE_HEADER_MULTI_READ) > +#define _TRACE_HYPERV_H > + > +#include > + > +#if IS_ENABLED(CONFIG_HYPERV) > + > +TRACE_EVENT(hyperv_mmu_flush_tlb_others, > + TP_PROTO(const struct cpumask *cpus, > + const struct flush_tlb_info *info), > + TP_ARGS(cpus, info), > + TP_STRUCT__entry( > + __field(unsigned int, ncpus) > + __field(struct mm_struct *, mm) > + __field(unsigned long, addr) > + __field(unsigned long, end) > + ), > + TP_fast_assign(__entry->ncpus = cpumask_weight(cpus); > + __entry->mm = info->mm; > + __entry->addr = info->start; > + __entry->end = info->end; > + ), > + TP_printk("ncpus %d mm %p addr %lx, end %lx", > + __entry->ncpus, __entry->mm, > + __entry->addr, __entry->end) > + ); > + > +#endif /* CONFIG_HYPERV */ > + > +#undef TRACE_INCLUDE_PATH > +#define TRACE_INCLUDE_PATH asm/trace/ Sometimes adding the include path in the make file may be easier. But this is fine too. -- Steve > +#undef TRACE_INCLUDE_FILE > +#define TRACE_INCLUDE_FILE hyperv > +#endif /* _TRACE_HYPERV_H */ > + > +/* This part must be outside protection */ > +#include