public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
	Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH v4 2/9] perf annotate: Initialize proper width for first column
Date: Thu, 27 Jul 2017 13:54:34 -0300	[thread overview]
Message-ID: <20170727165434.GC16224@kernel.org> (raw)
In-Reply-To: <1501172156-6673-1-git-send-email-treeze.taeung@gmail.com>

Em Fri, Jul 28, 2017 at 01:15:56AM +0900, Taeung Song escreveu:
> When using --show-total-period or not,
> set the width value for first column.
> 
> Suggested-by: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
>  tools/perf/util/annotate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index 5963764..5125c2b 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -1165,7 +1165,7 @@ static int disasm_line__print(struct disasm_line *dl, struct symbol *sym, u64 st
>  	} else if (max_lines && printed >= max_lines)
>  		return 1;
>  	else {
> -		int width = 8;
> +		int width = symbol_conf.show_total_period ? 12 : 8;
>  
>  		if (queue)
>  			return -1;
> @@ -1806,7 +1806,7 @@ int symbol__annotate_printf(struct symbol *sym, struct map *map,
>  	int printed = 2, queue_len = 0;
>  	int more = 0;
>  	u64 len;
> -	int width = 8;
> +	int width = symbol_conf.show_total_period ? 12 : 8;
>  	int graph_dotted_len;

Already at:

https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=ce9ee4a2de20062a97ad50ecc11ebda7e7618fd1

- Arnaldo

      reply	other threads:[~2017-07-27 16:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27 16:15 [PATCH v4 2/9] perf annotate: Initialize proper width for first column Taeung Song
2017-07-27 16:54 ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170727165434.GC16224@kernel.org \
    --to=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=treeze.taeung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox