From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751722AbdG1BrO (ORCPT ); Thu, 27 Jul 2017 21:47:14 -0400 Received: from smtprelay0228.hostedemail.com ([216.40.44.228]:42441 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751626AbdG1BrN (ORCPT ); Thu, 27 Jul 2017 21:47:13 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:69:355:379:541:599:800:960:981:982:988:989:1183:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3167:3352:3622:3865:3867:3868:3871:3872:4321:4605:5007:6120:6261:7576:7875:10004:10400:10848:10967:11026:11232:11658:11914:12043:12291:12296:12555:12683:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21433:21451:21627:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: bells65_3ed54c1307348 X-Filterd-Recvd-Size: 2268 Date: Thu, 27 Jul 2017 21:47:08 -0400 From: Steven Rostedt To: Borislav Petkov Cc: linux-edac , Tony Luck , Yazen Ghannam , X86 ML , LKML Subject: Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Message-ID: <20170727214708.24396586@vmware.local.home> In-Reply-To: <20170725154601.27427-7-bp@alien8.de> References: <20170725154601.27427-1-bp@alien8.de> <20170725154601.27427-7-bp@alien8.de> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Jul 2017 17:45:59 +0200 Borislav Petkov wrote: > From: Borislav Petkov > > Convert the part which decodes the error description to the sequence > buffer facility and thus save ourselves the many printk() invocations > building the decoded string. > > No functionality change. > > Signed-off-by: Borislav Petkov > --- > drivers/edac/mce_amd.c | 203 ++++++++++++++++++++++++++----------------------- > 1 file changed, 108 insertions(+), 95 deletions(-) > > diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c > index a11a671c7a38..1f5e9bb161f3 100644 > --- a/drivers/edac/mce_amd.c > +++ b/drivers/edac/mce_amd.c > @@ -1,3 +1,4 @@ > +#include > #include > #include > > @@ -306,6 +307,11 @@ static struct smca_mce_desc smca_mce_descs[] = { > [SMCA_SMU] = { smca_smu_mce_desc, ARRAY_SIZE(smca_smu_mce_desc) }, > }; > > +/* 128 because, well, nice and round - two cachelines. */ > +#define BUF_LEN 128 > +static char __err_buf[BUF_LEN]; > +static struct seq_buf sb; What happens if two CPUs have mce's at the same time? Wouldn't one corrupt the other buffer. 128 isn't too big to put on the stack is it? -- Steve > + > static bool f12h_mc0_mce(u16 ec, u8 xec) > {