* [RFC GIT PULL rcu/next] RCU/hotplug fix
@ 2017-07-28 0:35 Paul E. McKenney
2017-08-15 8:43 ` Ingo Molnar
0 siblings, 1 reply; 6+ messages in thread
From: Paul E. McKenney @ 2017-07-28 0:35 UTC (permalink / raw)
To: mingo
Cc: jhugo, tglx, bigeasy, anna-maria, boris.ostrovsky, richard,
linux-kernel
Hello, Ingo,
This pull request is for an RCU change that permits waiting for grace
periods started by CPUs late in the process of going offline. Lack of
this capability is causing failures:
http://lkml.kernel.org/r/db9c91f6-1b17-6136-84f0-03c3c2581ab4@codeaurora.org
Although these failures predate v4.12, and thus are in some sense not
regressions, it would be good for them to be fixed sooner rather than
later, hence this RFC pull request.
This commit was posted to LKML:
http://lkml.kernel.org/r/1500933116-11642-2-git-send-email-paulmck@linux.vnet.ibm.com
This commit has been exposed to 0day test robot and -next testing
and is available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git for-mingo
for you to fetch changes up to a58163d8ca2c8d288ee9f95989712f98473a5ac2:
rcu: Migrate callbacks earlier in the CPU-offline timeline (2017-07-25 13:03:43 -0700)
----------------------------------------------------------------
Paul E. McKenney (1):
rcu: Migrate callbacks earlier in the CPU-offline timeline
include/linux/rcupdate.h | 1 +
kernel/cpu.c | 1 +
kernel/rcu/tree.c | 209 +++++++++++++++++++++++++----------------------
3 files changed, 115 insertions(+), 96 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC GIT PULL rcu/next] RCU/hotplug fix 2017-07-28 0:35 [RFC GIT PULL rcu/next] RCU/hotplug fix Paul E. McKenney @ 2017-08-15 8:43 ` Ingo Molnar 2017-08-23 16:24 ` Jeffrey Hugo 0 siblings, 1 reply; 6+ messages in thread From: Ingo Molnar @ 2017-08-15 8:43 UTC (permalink / raw) To: Paul E. McKenney Cc: jhugo, tglx, bigeasy, anna-maria, boris.ostrovsky, richard, linux-kernel * Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote: > Hello, Ingo, > > This pull request is for an RCU change that permits waiting for grace > periods started by CPUs late in the process of going offline. Lack of > this capability is causing failures: > > http://lkml.kernel.org/r/db9c91f6-1b17-6136-84f0-03c3c2581ab4@codeaurora.org > > Although these failures predate v4.12, and thus are in some sense not > regressions, it would be good for them to be fixed sooner rather than > later, hence this RFC pull request. > > This commit was posted to LKML: > > http://lkml.kernel.org/r/1500933116-11642-2-git-send-email-paulmck@linux.vnet.ibm.com > > This commit has been exposed to 0day test robot and -next testing > and is available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git for-mingo > > for you to fetch changes up to a58163d8ca2c8d288ee9f95989712f98473a5ac2: > > rcu: Migrate callbacks earlier in the CPU-offline timeline (2017-07-25 13:03:43 -0700) > > ---------------------------------------------------------------- > Paul E. McKenney (1): > rcu: Migrate callbacks earlier in the CPU-offline timeline > > include/linux/rcupdate.h | 1 + > kernel/cpu.c | 1 + > kernel/rcu/tree.c | 209 +++++++++++++++++++++++++---------------------- > 3 files changed, 115 insertions(+), 96 deletions(-) Pulled, thanks Paul! Ingo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC GIT PULL rcu/next] RCU/hotplug fix 2017-08-15 8:43 ` Ingo Molnar @ 2017-08-23 16:24 ` Jeffrey Hugo 2017-08-24 7:53 ` Ingo Molnar 0 siblings, 1 reply; 6+ messages in thread From: Jeffrey Hugo @ 2017-08-23 16:24 UTC (permalink / raw) To: Ingo Molnar, Paul E. McKenney Cc: tglx, bigeasy, anna-maria, boris.ostrovsky, richard, linux-kernel On 8/15/2017 2:43 AM, Ingo Molnar wrote: > > * Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote: > >> Hello, Ingo, >> >> This pull request is for an RCU change that permits waiting for grace >> periods started by CPUs late in the process of going offline. Lack of >> this capability is causing failures: >> >> http://lkml.kernel.org/r/db9c91f6-1b17-6136-84f0-03c3c2581ab4@codeaurora.org >> >> Although these failures predate v4.12, and thus are in some sense not >> regressions, it would be good for them to be fixed sooner rather than >> later, hence this RFC pull request. >> >> This commit was posted to LKML: >> >> http://lkml.kernel.org/r/1500933116-11642-2-git-send-email-paulmck@linux.vnet.ibm.com >> >> This commit has been exposed to 0day test robot and -next testing >> and is available in the git repository at: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git for-mingo >> >> for you to fetch changes up to a58163d8ca2c8d288ee9f95989712f98473a5ac2: >> >> rcu: Migrate callbacks earlier in the CPU-offline timeline (2017-07-25 13:03:43 -0700) >> >> ---------------------------------------------------------------- >> Paul E. McKenney (1): >> rcu: Migrate callbacks earlier in the CPU-offline timeline >> >> include/linux/rcupdate.h | 1 + >> kernel/cpu.c | 1 + >> kernel/rcu/tree.c | 209 +++++++++++++++++++++++++---------------------- >> 3 files changed, 115 insertions(+), 96 deletions(-) > > Pulled, thanks Paul! > > Ingo > Ingo, We've been keeping an eye on this fix, so I'm trying to ascertain it's status. For my information, is this expected to hit Linus' tree in 4.13, or wait until the 4.14 merge window? Thanks -- Jeffrey Hugo Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC GIT PULL rcu/next] RCU/hotplug fix 2017-08-23 16:24 ` Jeffrey Hugo @ 2017-08-24 7:53 ` Ingo Molnar 2017-08-24 14:35 ` Paul E. McKenney 0 siblings, 1 reply; 6+ messages in thread From: Ingo Molnar @ 2017-08-24 7:53 UTC (permalink / raw) To: Jeffrey Hugo Cc: Paul E. McKenney, tglx, bigeasy, anna-maria, boris.ostrovsky, richard, linux-kernel * Jeffrey Hugo <jhugo@codeaurora.org> wrote: > > > This commit has been exposed to 0day test robot and -next testing > > > and is available in the git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git for-mingo > > > > > > for you to fetch changes up to a58163d8ca2c8d288ee9f95989712f98473a5ac2: > > > > > > rcu: Migrate callbacks earlier in the CPU-offline timeline (2017-07-25 13:03:43 -0700) > > > > > > ---------------------------------------------------------------- > > > Paul E. McKenney (1): > > > rcu: Migrate callbacks earlier in the CPU-offline timeline > > > > > > include/linux/rcupdate.h | 1 + > > > kernel/cpu.c | 1 + > > > kernel/rcu/tree.c | 209 +++++++++++++++++++++++++---------------------- > > > 3 files changed, 115 insertions(+), 96 deletions(-) > > > > Pulled, thanks Paul! > > > > Ingo > > > > Ingo, > > We've been keeping an eye on this fix, so I'm trying to ascertain it's status. > For my information, is this expected to hit Linus' tree in 4.13, or wait until > the 4.14 merge window? It's for v4.14, it's a pretty large (and thus risky) commit that came in relatively late. If it's problem-free it can be sent to -stable. If Paul insists I can try and send it to Linus, but it's getting fairly late in the cycle. Thanks, Ingo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC GIT PULL rcu/next] RCU/hotplug fix 2017-08-24 7:53 ` Ingo Molnar @ 2017-08-24 14:35 ` Paul E. McKenney 2017-08-24 14:49 ` Jeffrey Hugo 0 siblings, 1 reply; 6+ messages in thread From: Paul E. McKenney @ 2017-08-24 14:35 UTC (permalink / raw) To: Ingo Molnar Cc: Jeffrey Hugo, tglx, bigeasy, anna-maria, boris.ostrovsky, richard, linux-kernel On Thu, Aug 24, 2017 at 09:53:20AM +0200, Ingo Molnar wrote: > > * Jeffrey Hugo <jhugo@codeaurora.org> wrote: > > > > > This commit has been exposed to 0day test robot and -next testing > > > > and is available in the git repository at: > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git for-mingo > > > > > > > > for you to fetch changes up to a58163d8ca2c8d288ee9f95989712f98473a5ac2: > > > > > > > > rcu: Migrate callbacks earlier in the CPU-offline timeline (2017-07-25 13:03:43 -0700) > > > > > > > > ---------------------------------------------------------------- > > > > Paul E. McKenney (1): > > > > rcu: Migrate callbacks earlier in the CPU-offline timeline > > > > > > > > include/linux/rcupdate.h | 1 + > > > > kernel/cpu.c | 1 + > > > > kernel/rcu/tree.c | 209 +++++++++++++++++++++++++---------------------- > > > > 3 files changed, 115 insertions(+), 96 deletions(-) > > > > > > Pulled, thanks Paul! > > > > > > Ingo > > > > > > > Ingo, > > > > We've been keeping an eye on this fix, so I'm trying to ascertain it's status. > > For my information, is this expected to hit Linus' tree in 4.13, or wait until > > the 4.14 merge window? > > It's for v4.14, it's a pretty large (and thus risky) commit that came in > relatively late. If it's problem-free it can be sent to -stable. > > If Paul insists I can try and send it to Linus, but it's getting fairly late > in the cycle. Hugo, I was interpreting your email of August 22nd as meaning that the problem no longer existed in mainline: https://marc.info/?l=linux-kernel&m=150343524911301&w=2 If my interpretation is correct, then this commit can wait until the upcoming merge window. As Ingo says, I can send patches to -stable (and backporting is required, BTW). If my interpretation is incorrect, please let me know what the situation really is. Thanx, Paul ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC GIT PULL rcu/next] RCU/hotplug fix 2017-08-24 14:35 ` Paul E. McKenney @ 2017-08-24 14:49 ` Jeffrey Hugo 0 siblings, 0 replies; 6+ messages in thread From: Jeffrey Hugo @ 2017-08-24 14:49 UTC (permalink / raw) To: paulmck, Ingo Molnar Cc: tglx, bigeasy, anna-maria, boris.ostrovsky, richard, linux-kernel On 8/24/2017 8:35 AM, Paul E. McKenney wrote: > On Thu, Aug 24, 2017 at 09:53:20AM +0200, Ingo Molnar wrote: >> >> * Jeffrey Hugo <jhugo@codeaurora.org> wrote: >> >>>>> This commit has been exposed to 0day test robot and -next testing >>>>> and is available in the git repository at: >>>>> >>>>> git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git for-mingo >>>>> >>>>> for you to fetch changes up to a58163d8ca2c8d288ee9f95989712f98473a5ac2: >>>>> >>>>> rcu: Migrate callbacks earlier in the CPU-offline timeline (2017-07-25 13:03:43 -0700) >>>>> >>>>> ---------------------------------------------------------------- >>>>> Paul E. McKenney (1): >>>>> rcu: Migrate callbacks earlier in the CPU-offline timeline >>>>> >>>>> include/linux/rcupdate.h | 1 + >>>>> kernel/cpu.c | 1 + >>>>> kernel/rcu/tree.c | 209 +++++++++++++++++++++++++---------------------- >>>>> 3 files changed, 115 insertions(+), 96 deletions(-) >>>> >>>> Pulled, thanks Paul! >>>> >>>> Ingo >>>> >>> >>> Ingo, >>> >>> We've been keeping an eye on this fix, so I'm trying to ascertain it's status. >>> For my information, is this expected to hit Linus' tree in 4.13, or wait until >>> the 4.14 merge window? >> >> It's for v4.14, it's a pretty large (and thus risky) commit that came in >> relatively late. If it's problem-free it can be sent to -stable. >> >> If Paul insists I can try and send it to Linus, but it's getting fairly late >> in the cycle. > > Hugo, I was interpreting your email of August 22nd as meaning that > the problem no longer existed in mainline: > > https://marc.info/?l=linux-kernel&m=150343524911301&w=2 > > If my interpretation is correct, then this commit can wait until the > upcoming merge window. As Ingo says, I can send patches to -stable > (and backporting is required, BTW). > > If my interpretation is incorrect, please let me know what the situation > really is. > > Thanx, Paul > Sorry for any confusion. Yes, that interpretation is correct. I agree, it is late in the cycle, and I am not advocating for inclusion into 4.13. We have internal processes concerning upstream fixes, and it is helpful to identify exactly when a fix is expected to hit Linus' tree - none of which is particularly important or relevant to the community, I'm just trying to bridge a few gaps. 4.14 merge window is perfectly fine. I will plan on that. Thanks for the clarification, and a huge thanks for looking at the issue and solving it. -- Jeffrey Hugo Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-24 14:49 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-07-28 0:35 [RFC GIT PULL rcu/next] RCU/hotplug fix Paul E. McKenney 2017-08-15 8:43 ` Ingo Molnar 2017-08-23 16:24 ` Jeffrey Hugo 2017-08-24 7:53 ` Ingo Molnar 2017-08-24 14:35 ` Paul E. McKenney 2017-08-24 14:49 ` Jeffrey Hugo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).