From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751751AbdG1Gh7 (ORCPT ); Fri, 28 Jul 2017 02:37:59 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:37238 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751163AbdG1Gh5 (ORCPT ); Fri, 28 Jul 2017 02:37:57 -0400 Date: Fri, 28 Jul 2017 08:37:53 +0200 From: Ingo Molnar To: Borislav Petkov Cc: linux-edac , Steven Rostedt , Tony Luck , Yazen Ghannam , X86 ML , LKML Subject: Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Message-ID: <20170728063753.qjdn2wt4j54bo2oi@gmail.com> References: <20170725154601.27427-1-bp@alien8.de> <20170727071034.epbwwmgnbj6dv4sf@gmail.com> <20170727075845.GD4690@nazgul.tnic> <20170727083927.jzpzeyzdoaqnxrfm@gmail.com> <20170727130909.GB28548@nazgul.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170727130909.GB28548@nazgul.tnic> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > BUT(!), I just realized, I *think* I can address this much more elegantly: > extend trace_mce_record() by adding the decoded string as its last argument. And > that's fine, I'm being told, because adding arguments to the tracepoints is not > a big deal, removing them is hard. And actually, we have added args before, come > to think of it: Yeah, structured, append-only ABIs are elegant - that's what perf uses too. > I agree with the rest but you're obviously preaching to the choir. > > :-) Had do vent my (non kernel tree integrated) Linux tooling frustration!! ;-) Thanks, Ingo