From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752037AbdG1NAG (ORCPT ); Fri, 28 Jul 2017 09:00:06 -0400 Received: from smtprelay0192.hostedemail.com ([216.40.44.192]:34085 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751806AbdG1NAD (ORCPT ); Fri, 28 Jul 2017 09:00:03 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 30,2,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3167:3352:3622:3865:3866:3867:3870:3871:3872:4321:5007:6120:6261:7875:10010:10400:10848:10967:11232:11658:11914:12043:12050:12740:12760:12895:13069:13311:13357:13439:14096:14097:14181:14659:14721:21080:21433:21627:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:1:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: truck99_749f2098b885f X-Filterd-Recvd-Size: 2035 Date: Fri, 28 Jul 2017 08:59:59 -0400 From: Steven Rostedt To: Borislav Petkov Cc: linux-edac , Tony Luck , Yazen Ghannam , X86 ML , LKML Subject: Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Message-ID: <20170728085959.126297dc@vmware.local.home> In-Reply-To: <20170728105140.GF1884@nazgul.tnic> References: <20170725154601.27427-1-bp@alien8.de> <20170725154601.27427-7-bp@alien8.de> <20170727214708.24396586@vmware.local.home> <20170728070933.GA1884@nazgul.tnic> <20170728105140.GF1884@nazgul.tnic> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Jul 2017 12:51:40 +0200 Borislav Petkov wrote: > On Fri, Jul 28, 2017 at 09:09:33AM +0200, Borislav Petkov wrote: > > On Thu, Jul 27, 2017 at 09:47:08PM -0400, Steven Rostedt wrote: > > > What happens if two CPUs have mce's at the same time? Wouldn't one > > > corrupt the other buffer. 128 isn't too big to put on the stack is it? > > > > Yeah, putting it on the stack is probably safer, just in case. > > > > What is even better, though, is if I extended > > arch/x86/kernel/cpu/mcheck/mce-genpool.c to allocate a second buffer for the > > decoded strings. We use it for the struct mces right now. > > Here's a conversion to a 2-page backed genpool. Seems to work: Interesting, this is the first I heard of the genpool. I probably could have used this in other code. Good to know (learn something new every day :-) I'll have to take a look at it when I get home later today (still bouncing between airports). -- Steve