From: Martijn Coenen <maco@android.com>
To: gregkh@linuxfoundation.org, john.stultz@linaro.org,
tkjos@google.com, arve@android.com, amit.pundir@linaro.org
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
maco@google.com, Martijn Coenen <maco@android.com>
Subject: [PATCH 3/3] ANDROID: binder: fix proc->tsk check.
Date: Fri, 28 Jul 2017 13:56:08 +0200 [thread overview]
Message-ID: <20170728115608.61306-4-maco@android.com> (raw)
In-Reply-To: <20170728115608.61306-1-maco@android.com>
Commit c4ea41ba195d ("binder: use group leader instead of open thread")'
was incomplete and didn't update a check in binder_mmap(), causing all
mmap() calls into the binder driver to fail.
Signed-off-by: Martijn Coenen <maco@android.com>
---
drivers/android/binder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index f7665c31feca..831cdd7d197d 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -3362,7 +3362,7 @@ static int binder_mmap(struct file *filp, struct vm_area_struct *vma)
const char *failure_string;
struct binder_buffer *buffer;
- if (proc->tsk != current)
+ if (proc->tsk != current->group_leader)
return -EINVAL;
if ((vma->vm_end - vma->vm_start) > SZ_4M)
--
2.14.0.rc0.400.g1c36432dff-goog
next prev parent reply other threads:[~2017-07-28 11:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 11:56 [PATCH 0/3] ANDROID: binder: reconcile with android common tree Martijn Coenen
2017-07-28 11:56 ` [PATCH 1/3] ANDROID: binder: add padding to binder_fd_array_object Martijn Coenen
2017-07-28 11:56 ` [PATCH 2/3] ANDROID: binder: add hwbinder,vndbinder to BINDER_DEVICES Martijn Coenen
2017-07-28 11:56 ` Martijn Coenen [this message]
2017-07-31 5:25 ` [PATCH 3/3] ANDROID: binder: fix proc->tsk check Amit Pundir
2017-08-08 17:34 ` John Stultz
2017-08-08 18:08 ` Greg KH
2017-08-08 18:24 ` John Stultz
2017-08-21 18:48 ` John Stultz
2017-08-22 15:49 ` Greg KH
2017-08-23 1:43 ` Greg KH
2017-07-28 23:22 ` [PATCH 0/3] ANDROID: binder: reconcile with android common tree Greg KH
2017-07-31 6:55 ` Martijn Coenen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728115608.61306-4-maco@android.com \
--to=maco@android.com \
--cc=amit.pundir@linaro.org \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@google.com \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox