From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
maxime.ripard@free-electrons.com, wens@csie.org,
linux@armlinux.org.uk, peppe.cavallaro@st.com,
alexandre.torgue@st.com, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@googlegroups.com,
linux-arm-kernel@lists.infradead.org, icenowy@aosc.io
Subject: Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
Date: Fri, 28 Jul 2017 16:25:08 +0200 [thread overview]
Message-ID: <20170728142508.GA7221@Red> (raw)
In-Reply-To: <20170728135544.GD32230@lunn.ch>
On Fri, Jul 28, 2017 at 03:55:44PM +0200, Andrew Lunn wrote:
> On Fri, Jul 28, 2017 at 11:28:15AM +0200, Corentin Labbe wrote:
> > Hello
> >
> > The current way to find if the phy is internal is to compare DT phy-mode
> > and emac_variant/internal_phy.
> > But it will negate a possible future SoC where an external PHY use the
> > same phy mode than the internal one.
> >
> > This patchs series adds a new way to find if the PHY is internal, via its
> > compatible.
>
> http://elixir.free-electrons.com/linux/latest/source/drivers/of/of_mdio.c#L144
>
> Since you also have "ethernet-phy-ieee802.3-c22", you won't get the
> warning. But still, your device tree gives the wrong idea.
>
> I've probably asked this before: Does the internal PHY use a different
> PHY ID in registers 2 and 3?
>
yes
reg2: 0x0044
reg3: 0X1500
Regards
next prev parent reply other threads:[~2017-07-28 14:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 9:28 [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode Corentin Labbe
2017-07-28 9:28 ` [PATCH 1/3] dt-bindings: net: add compatible for internal sun8i-h3/sun8i-v3s PHYs Corentin Labbe
2017-07-28 9:28 ` [PATCH 2/3] ARM: sunxi: h3/h5: Add sun8i-h3-ephy compatible Corentin Labbe
2017-07-28 9:44 ` Chen-Yu Tsai
2017-07-28 9:46 ` Icenowy Zheng
2017-07-28 9:28 ` [PATCH 3/3] net-next: stmmac: dwmac-sun8i: choose internal PHY via compatible Corentin Labbe
2017-07-28 9:49 ` Chen-Yu Tsai
2017-07-28 9:54 ` Corentin Labbe
2017-07-28 9:53 ` [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode Chen-Yu Tsai
2017-07-28 13:47 ` Andrew Lunn
2017-07-28 13:55 ` Andrew Lunn
2017-07-28 14:25 ` Corentin Labbe [this message]
2017-07-28 14:36 ` Andrew Lunn
2017-07-28 14:44 ` Corentin Labbe
2017-07-28 14:51 ` Andrew Lunn
2017-07-28 17:54 ` Florian Fainelli
2017-07-29 6:48 ` Corentin Labbe
2017-07-31 12:19 ` Chen-Yu Tsai
2017-07-31 12:26 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728142508.GA7221@Red \
--to=clabbe.montjoie@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).