From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752315AbdG1O6e (ORCPT ); Fri, 28 Jul 2017 10:58:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:41648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752098AbdG1O6d (ORCPT ); Fri, 28 Jul 2017 10:58:33 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD6B820C51 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Fri, 28 Jul 2017 11:58:30 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: =?iso-8859-1?Q?Genevi=E8ve?= Bastien , linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Mathieu Desnoyers , Julien Desfossez , Francis Deslauriers , Jiri Olsa Subject: Re: [PATCH 1/3] perf tools: Add callchain to ctf conversion Message-ID: <20170728145830.GA12201@kernel.org> References: <20170727181205.24843-1-gbastien@versatic.net> <20170728092550.GE23238@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170728092550.GE23238@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Jul 28, 2017 at 11:25:50AM +0200, Jiri Olsa escreveu: > On Thu, Jul 27, 2017 at 02:12:03PM -0400, Geneviève Bastien wrote: > > The field perf_callchain, if available, is added to the sampling > > events during the CTF conversion. It is an array of u64 values. > > The perf_callchain_size field contains the size of the array. > > > > It will allow the analysis of sampling data in trace visualization tools > > like Trace Compass. Possible analyses with those data: dynamic > > flamegraphs, correlation with other tracing data like a userspace trace. > > > > Here follows a babeltrace CTF output of a trace with callchain: > > > > $ babeltrace ./myctftrace > > [17:38:45.672760285] (+?.?????????) cycles:ppp: { cpu_id = 0 }, { perf_ip = 0xFFFFFFFF81063EE4, perf_tid = 25841, perf_pid = 25774, perf_period = 1, perf_callchain_size = 7, perf_callchain = [ [0] = 0xFFFFFFFFFFFFFF80, [1] = 0xFFFFFFFF81063EE4, [2] = 0xFFFFFFFF8100C770, [3] = 0xFFFFFFFF81006EC6, [4] = 0xFFFFFFFF8118245E, [5] = 0xFFFFFFFF810A9224, [6] = 0xFFFFFFFF8164A4C6 ] } > > [17:38:45.672777672] (+0.000017387) cycles:ppp: { cpu_id = 0 }, { perf_ip = 0xFFFFFFFF81063EE4, perf_tid = 25841, perf_pid = 25774, perf_period = 1, perf_callchain_size = 8, perf_callchain = [ [0] = 0xFFFFFFFFFFFFFF80, [1] = 0xFFFFFFFF81063EE4, [2] = 0xFFFFFFFF8100C770, [3] = 0xFFFFFFFF81006EC6, [4] = 0xFFFFFFFF8118245E, [5] = 0xFFFFFFFF810A9224, [6] = 0xFFFFFFFF8164A4C6, [7] = 0xFFFFFFFF8164ABAD ] } > > [17:38:45.672786700] (+0.000009028) cycles:ppp: { cpu_id = 0 }, { perf_ip = 0xFFFFFFFF81063EE4, perf_tid = 25841, perf_pid = 25774, perf_period = 70, perf_callchain_size = 3, perf_callchain = [ [0] = 0xFFFFFFFFFFFFFF80, [1] = 0xFFFFFFFF81063EE4, [2] = 0xFFFFFFFF8100C770 ] } > > missing one more hunk (attached) ;-) > > I guess there's no need to resend, Arnaldo could remove it, yeah, will do > anyway for patchset: > > Acked-by: Jiri Olsa Thanks! - Arnaldo > Is there already tracecompas change to display callchains and mmaps? > > thanks, > jirka > > > --- > diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c > index c47b0943ef88..2346cecb8ea2 100644 > --- a/tools/perf/util/data-convert-bt.c > +++ b/tools/perf/util/data-convert-bt.c > @@ -596,7 +596,6 @@ static int add_generic_values(struct ctf_writer *cw, > * PERF_SAMPLE_TIME - not needed as we have it in > * ctf event header > * PERF_SAMPLE_READ - TODO > - * PERF_SAMPLE_CALLCHAIN - TODO > * PERF_SAMPLE_RAW - tracepoint fields are handled separately > * PERF_SAMPLE_BRANCH_STACK - TODO > * PERF_SAMPLE_REGS_USER - TODO