Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

Corentin Labbe
2017-06-06T14:24:30Z

On Tue, Jun 06, 2017 at 04:07:25PM +0200, Stephan Müller wrote:
> Am Dienstag, 6. Juni 2017, 15:44:17 CEST schrieb Corentin Labbe:
>
> Hi Corentin,
>
> > The crypto engine could actually only enqueue hash and ablkcipher request.
> > This patch permit it to enqueue skcipher requets by adding all necessary
> > functions.
> > The only problem is that ablkcipher and skcipher id are the same, so
> > only one cipher type is usable on the same crypto engine.
>
> Why do you think this is needed? I thought that skcipher is the successor to
> ablkcipher AND blkcipher. I.e. ablkcipher and blkcipher should be phased out.
> Thus, I would infer that any ablkcipher support should or could be dropped.
>

There are two user of it, crypto/omap and crypto/virtio.
And for crypto/omap, I have no way of testing any convertion to skcipher (no hardware).

Regards
Corentin Labbe