Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

Herbert Xu
2017-06-23T06:48:59Z

On Mon, Jun 19, 2017 at 09:55:24AM +0200, Corentin Labbe wrote:
>
> Since there are two different user of "crypto engine + ablkcipher", it will be not easy to convert them in one serie. (I could do it, but I simply could not test it for OMAP (lack of hw))
> And any new user which want to use crypto engine+skcipher (like me with the sun8i-ce driver) are simply stuck.

You're right. We'll need to do this in a backwards-compatible way. In fact
we already do something similar in skcipher.c itself. Simply look at the
cra_type field and if it matches blkcipher/ablkcipher/givcipher then it's
legacy ablkcipher, otherwise it's skcipher.

Also the way crypto_engine looks at the request type in the data-path is
suboptimal. This should really be built into the cra_type object. For
example, we can have cra_type->engine->prepare_request which would just
do the right thing.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt