From: Andrew Lunn <andrew@lunn.ch>
To: Salil Mehta <salil.mehta@huawei.com>
Cc: davem@davemloft.net, yisen.zhuang@huawei.com,
huangdaode@hisilicon.com, lipeng321@huawei.com,
mehta.salil.lnk@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC
Date: Sat, 29 Jul 2017 01:28:59 +0200 [thread overview]
Message-ID: <20170728232859.GB16080@lunn.ch> (raw)
In-Reply-To: <20170728222652.118448-7-salil.mehta@huawei.com>
> +int hclge_mac_mdio_config(struct hclge_dev *hdev)
> +{
..
> +}
> +
> +int hclge_mac_start_phy(struct hclge_dev *hdev)
> +{
> +}
> +
> +void hclge_mac_stop_phy(struct hclge_dev *hdev)
> +{
> +}
> --
These are not static functions. So i would expect them to be in a
header file somewhere....
Andrew
next prev parent reply other threads:[~2017-07-28 23:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 22:26 [PATCH V5 net-next 0/8] Hisilicon Network Subsystem 3 Ethernet Driver Salil Mehta
2017-07-28 22:26 ` [PATCH V5 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC Salil Mehta
2017-07-28 22:26 ` [PATCH V5 net-next 2/8] net: hns3: Add support of the HNAE3 framework Salil Mehta
2017-07-30 9:58 ` Leon Romanovsky
2017-07-31 9:04 ` Salil Mehta
2017-07-28 22:26 ` [PATCH V5 net-next 3/8] net: hns3: Add HNS3 IMP(Integrated Mgmt Proc) Cmd Interface Support Salil Mehta
2017-07-28 22:26 ` [PATCH V5 net-next 4/8] net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support Salil Mehta
2017-07-28 22:26 ` [PATCH V5 net-next 5/8] net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver Salil Mehta
2017-07-28 22:26 ` [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC Salil Mehta
2017-07-28 23:24 ` Andrew Lunn
2017-07-28 23:50 ` Salil Mehta
2017-07-28 23:28 ` Andrew Lunn [this message]
2017-07-28 23:52 ` Salil Mehta
2017-07-28 22:26 ` [PATCH V5 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver Salil Mehta
2017-07-28 23:49 ` Andrew Lunn
2017-07-28 23:57 ` Salil Mehta
2017-07-31 15:05 ` Salil Mehta
2017-07-28 22:26 ` [PATCH V5 net-next 8/8] net: hns3: Add HNS3 driver to kernel build framework & MAINTAINERS Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728232859.GB16080@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=huangdaode@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mehta.salil.lnk@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox