* [PATCH] md: replace seq_release_private with seq_release
@ 2017-07-29 16:52 Cihangir Akturk
2017-07-31 16:49 ` Shaohua Li
0 siblings, 1 reply; 2+ messages in thread
From: Cihangir Akturk @ 2017-07-29 16:52 UTC (permalink / raw)
To: shli; +Cc: linux-raid, linux-kernel, Cihangir Akturk
Since commit f15146380d28 ("fs: seq_file - add event counter to simplify
poll() support"), md.c code has been no longer used the private field of
the struct seq_file, but seq_release_private() has been continued to be
used to release the allocated seq_file. This seems to have been
forgotten. So convert it to use seq_release() instead of
seq_release_private().
Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
---
drivers/md/md.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 8cdca029..6174360 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -7836,7 +7836,7 @@ static const struct file_operations md_seq_fops = {
.open = md_seq_open,
.read = seq_read,
.llseek = seq_lseek,
- .release = seq_release_private,
+ .release = seq_release,
.poll = mdstat_poll,
};
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] md: replace seq_release_private with seq_release
2017-07-29 16:52 [PATCH] md: replace seq_release_private with seq_release Cihangir Akturk
@ 2017-07-31 16:49 ` Shaohua Li
0 siblings, 0 replies; 2+ messages in thread
From: Shaohua Li @ 2017-07-31 16:49 UTC (permalink / raw)
To: Cihangir Akturk; +Cc: linux-raid, linux-kernel
On Sat, Jul 29, 2017 at 07:52:45PM +0300, Cihangir Akturk wrote:
> Since commit f15146380d28 ("fs: seq_file - add event counter to simplify
> poll() support"), md.c code has been no longer used the private field of
> the struct seq_file, but seq_release_private() has been continued to be
> used to release the allocated seq_file. This seems to have been
> forgotten. So convert it to use seq_release() instead of
> seq_release_private().
>
> Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
applied, thanks!
> ---
> drivers/md/md.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 8cdca029..6174360 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -7836,7 +7836,7 @@ static const struct file_operations md_seq_fops = {
> .open = md_seq_open,
> .read = seq_read,
> .llseek = seq_lseek,
> - .release = seq_release_private,
> + .release = seq_release,
> .poll = mdstat_poll,
> };
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-31 16:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-29 16:52 [PATCH] md: replace seq_release_private with seq_release Cihangir Akturk
2017-07-31 16:49 ` Shaohua Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox