From: Stephen Hemminger <stephen@networkplumber.org>
To: mohamedalrshah <mohamed.asnd@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
mohamed.a.alrshah@ieee.org
Subject: Re: [PATCH] Adding Agile-SD TCP module and modifying Kconfig and Makefile to configure the kernel for this new module to configure the kernel for this new module.
Date: Tue, 1 Aug 2017 07:49:31 -0700 [thread overview]
Message-ID: <20170801074931.34102262@xeon-e3> (raw)
In-Reply-To: <20170801095005.16025-1-mohamed.asnd@gmail.com>
On Tue, 1 Aug 2017 17:50:05 +0800
mohamedalrshah <mohamed.asnd@gmail.com> wrote:
> From: Mohamed Alrshah <mohamed.asnd@gmail.com>
>
Please add more background on Agile-SD in the email commit message.
> +static struct tcp_congestion_ops agilesdtcp __read_mostly = {
> + .init = agilesdtcp_init,
> + .ssthresh = agilesdtcp_recalc_ssthresh, //REQUIRED
> + .cong_avoid = agilesdtcp_cong_avoid, //REQUIRED
> + .set_state = agilesdtcp_state,
> + .undo_cwnd = agilesdtcp_undo_cwnd,
> + .pkts_acked = agilesdtcp_acked,
> + .owner = THIS_MODULE,
> + .name = "agilesd", //REQUIRED
> + //.min_cwnd = agilesdtcp_min_cwnd, //NOT REQUIRED
> +};
Your code must match kernel coding style. See Documentation for more
info and use the checkpatch.pl checking script.
prev parent reply other threads:[~2017-08-01 14:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 9:50 [PATCH] Adding Agile-SD TCP module and modifying Kconfig and Makefile to configure the kernel for this new module to configure the kernel for this new module mohamedalrshah
2017-08-01 14:49 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801074931.34102262@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mohamed.a.alrshah@ieee.org \
--cc=mohamed.asnd@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox