From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751928AbdHAOth (ORCPT ); Tue, 1 Aug 2017 10:49:37 -0400 Received: from mail-pg0-f48.google.com ([74.125.83.48]:36799 "EHLO mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700AbdHAOtf (ORCPT ); Tue, 1 Aug 2017 10:49:35 -0400 Date: Tue, 1 Aug 2017 07:49:31 -0700 From: Stephen Hemminger To: mohamedalrshah Cc: davem@davemloft.net, netdev@vger.kernel.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, mohamed.a.alrshah@ieee.org Subject: Re: [PATCH] Adding Agile-SD TCP module and modifying Kconfig and Makefile to configure the kernel for this new module to configure the kernel for this new module. Message-ID: <20170801074931.34102262@xeon-e3> In-Reply-To: <20170801095005.16025-1-mohamed.asnd@gmail.com> References: <20170801095005.16025-1-mohamed.asnd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Aug 2017 17:50:05 +0800 mohamedalrshah wrote: > From: Mohamed Alrshah > Please add more background on Agile-SD in the email commit message. > +static struct tcp_congestion_ops agilesdtcp __read_mostly = { > + .init = agilesdtcp_init, > + .ssthresh = agilesdtcp_recalc_ssthresh, //REQUIRED > + .cong_avoid = agilesdtcp_cong_avoid, //REQUIRED > + .set_state = agilesdtcp_state, > + .undo_cwnd = agilesdtcp_undo_cwnd, > + .pkts_acked = agilesdtcp_acked, > + .owner = THIS_MODULE, > + .name = "agilesd", //REQUIRED > + //.min_cwnd = agilesdtcp_min_cwnd, //NOT REQUIRED > +}; Your code must match kernel coding style. See Documentation for more info and use the checkpatch.pl checking script.