Re: [PATCH 2/3] GHES: Move memory initialisation to ghes_probe()

Borislav Petkov
2017-08-15T10:19:12Z

On Tue, Aug 15, 2017 at 11:10:05AM +0100, Punit Agrawal wrote:
> In the absence of any GHES entries these are wasted.

I know. This whole APEI init code would need a proper cleanup, like
acpi_pci_root_init() calls acpi_hest_init() and it shouldn't have to
communicate through a variable with GHES whether to init or not but it
should initialize GHES itself. And ghes_init() being a device_initcall()
is just yuck.

Something for the todo list I guess...

> The system does not provide the Hardware Error Source Table (HEST) which
> is checked in the hest driver (drivers/acpi/apei/hest.c).
>
> I think I'll go with your original suggestion to change hest_disable
> from a boolean to something with more states. Re-checking for the HEST
> table again feels like duplication.
>
> Makes sense?

Right, and then depending on the setting of hest_disable, either issue
the "HEST is not enabled" message or not.

Thanks.

--
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--