From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751999AbdHASO3 (ORCPT ); Tue, 1 Aug 2017 14:14:29 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:33067 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752052AbdHASOX (ORCPT ); Tue, 1 Aug 2017 14:14:23 -0400 Date: Tue, 1 Aug 2017 19:13:52 +0100 From: Roman Gushchin To: Michal Hocko CC: , Vladimir Davydov , Johannes Weiner , Tetsuo Handa , David Rientjes , Tejun Heo , , , , Subject: Re: [v4 2/4] mm, oom: cgroup-aware OOM killer Message-ID: <20170801181352.GA26074@castle.DHCP.thefacebook.com> References: <20170726132718.14806-1-guro@fb.com> <20170726132718.14806-3-guro@fb.com> <20170801145435.GN15774@dhcp22.suse.cz> <20170801152548.GA29502@castle.dhcp.TheFacebook.com> <20170801170302.GB15518@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170801170302.GB15518@dhcp22.suse.cz> User-Agent: Mutt/1.8.3 (2017-05-23) X-Originating-IP: [2620:10d:c092:200::1:5aeb] X-ClientProxiedBy: AM3PR03CA0074.eurprd03.prod.outlook.com (2603:10a6:207:5::32) To CO1PR15MB1077.namprd15.prod.outlook.com (2a01:111:e400:7b66::7) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1e36ca08-9c98-45dd-355c-08d4d90918da X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CO1PR15MB1077; X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1077;3:Gxk7rQxClhrZJg078H01I7bBSviLsQP/+23ODCjx40q57dQLa1f9eBJ3VvfpSBv1BCl2aTezjdFDZ3fpHTYzwmRk0NTZzgEtBvVW/Cb59RMNEJiY4DGUOtF5jJbhbP0rS3S8mhSSoG9PSVzwWNlZO32VPUWXnvvy8POLSKC4mCmWfVbQy48DE2P6/AMLD9OyTWJtUmrjcW4z/9s0TQY8xk1IQCxAIJRnt/3MikLh3yJ4cd3YfNO36AfCEHRl+r0qpqdFphNklTEuEQvCv6BI2kK/rzHDo3dNN0dkHfgAY4f7taxoiq1oB7eAOop9Ihva/mARhER6LxCwom7kSry4AlbbZsZUCxgVXj/u7+kvh1xZdDb8qTSb+THjA0zgLvIT8C1pqA0rEjyGbNaz1LfaRr66VVyxhIhK1xsw1mnahvdBmeZ6ULKq7JDuYsOHgw7JPHUwTmGykqbSgsiuAkTQCHO+HyHT18wlXvThWzrTdTUZnizxf5XsakQwNxwkfO2iCAxnRzyDWZ4xfnHvzdBVeVD9Z4TivyN8BK1HDqfJZh6M1BFkSO1fuXbW7K91DXP17/g1s6cvyCUCjK2tWeE0uR9cYraR2hm79Dp9z9tNUxx3GpdZ13yGB4iZQ0zreItuJP8A5JQ4ktM5yglFpIO0W4iNxEebk8TMjyOFNg0AQmmBg5jhPOf8qKBni2ifDe8rt1CrxP8/Zgt0pXZ6dmKy2hYjevGyaCR9hanfb7CRTNAAvdTTecF4vr6PZFhfAcw854+pBcZG1QaeYVxFnrFRcR8wmGRlp9ESmYzlyBOIDw7cIBXEZusagC1SVW5eZCs1 X-MS-TrafficTypeDiagnostic: CO1PR15MB1077: X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1077;25:9NDec3E/2ucQqz/dvP+Sc+UwFT94gFCiAm8uNN6oN3Ug+vGjhlhUCemFtedfJsRSmbS9RL78vVWbCaMXLs8208cIdPhb99i9E1eK8GsQ/eR4leAzKSke4Qi0T6lUrtlVD/FYIMTKTimRnXS7fKci37Wt0o+7r1U7fv4ftjCWzghM0ugN6TH5mcK43xbHhiWx14nc/24w9Io32l7ZvohJIjCDiyvyqxEWeeWWAEvJ3Mp82OQtwISGS1wcBNuunDSU+1iBBpg/eJ+71eMiYyVgKFFEMZko83xuVLRMTBmT2O9GqHb8oWB3ZYDvEYj4MgLsSmW2l8hgFiTQvbuPForZGl2Z4Sf49R2Vra3Eb+RvuDZksS6sRFSlG6nxQpIIU2YdbmM1uYEB2peaf9iEYkP2mwBjw/2xcMAMHbwggNGUQjfN+i/SoJ6EzTMBHwp6Lc/Fo13YW1J+q7fIdowgIZMZdpVBWuEITR6G+t50id4/Yjqi1NhzC88lzx5GUvUZbvL9Fl50GwirZTMKLphtX8x59Gy2GfKSqCu+DWEXzLHGrMc1xQPR4Q53K2N43vLAiu9WQ4aWe6eBywuZgojsvy8kLDIJ/rymi4ljitvZ71q1jGQt23igGXjN6mG6ZadIg3KRLtD1E2h8XusM0jc8Q213h0R16hsJVjHWnMqpdhF5SnxyVQQrTvd6/JvWpl62Lf9E/N1a7VtURGLYJZn9i5PhQZf2G970hQ8o/t6myJ5Y5+poxXtM0BNqJ07FpxRLsguFdTDQISDm/Mp+0r+hnrt2UxP05+ROyQR/joIJEe0hSaGzip53vP7pTH66qpxp6c3Jbe/+EZnvoEfxQSTMKjWzGnWRu+NTBiWpBMz3M2Wg0eb4xuIrdHez4RRS81jAJUpABKWzYVC9UHm1SEDe95UZveRps9Mh0ocRgtlmjo2ghtE= X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1077;31:nMsje9Y11t4o8gFG7sRoIsdA2z/b+U8KmAKtJEVyk94B689KuDUxIC45D+g+26U1JdviZOsECvV7vU3SZBgda9lrNmnRSs/NBbYk9mOyYQU/wNx7nTC+zEepxblJc6w10X+EGXlA95bpeAA2yajb9W0yQ7BmY8XuoVzqfOoUuZbC+DNp85Kb3godtpnUdnI1Wd/aDs74gfINVe8H/mNOZ80gd0wEZb0rbanmyEosWMYA6q/nn/RUzJ3zSUVgLorQA0t7Nlhk6Yz1981YULlL+erd/pTfT2UPwc65ECg/zstg0l2r3RMFZINtuvp5f5cUxePJ/vIBVF3yKBM7NMRQ15ppowT3XsFUhBM4FykVKHtG9T7A36dBrT5hYaBoRhgZtMNDvFYcxWqvGrvl7z+aWHwdAgbGscpcYScgqV6M+c2DH8yr5vrNRP3+9ePdEpis3pM+8qaB+pJ0ce6US/mPPH6N8Sc5Rw46XdQyIsvAqEfIKMLDNSMVA0KzPX2WFM0BHSyuRcK/6r7aQHMLs7i/zISa+XsCeAuDRjg8RRvtF8lyoH2t/EvfQrG8FKJMsLRDRSTI5TFzVcM50qw1Rvoek9/+muuHIrFVRNwOb00HuZwEzHDssVANPaQI4EL8FIO/0WMLhhTCpucCZsojWuAcBihujY0fTuecwFTRlbpF11U= X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1077;20:kLubNuuUuQeY0jIK8MEswJm5nOv8yMTmTC2taZcE1JxXNqI8lDvBP2tAQLYb28GNF8WRzuTmj86ra2cK1WaMdjwt7k0cqbGQBBQCTt2C+gK/Fe9GDkduArpDh7HC8g8fb2tIpm/TYY5nh3Kk1W15FrQqcIIeCpclVYvBn3XE3Y0GhhokXQFTvGZ9Wt8VSTONate/jF1CtU+EaP8WUMjBi2qW/Zb6QHD9bD4ijba1yuAWEF31zmik2NCCXyHmznl9x/A6kFToTw4jkxe/8U1qNEP/b2uG21Mcin3vgKbhjVOUVnv8i5CDwYhl8pnZGlEp1t5TpYPY3dh72VzYtcE47oNnpKA6DQKvzjHicUNljn2AFe/g6AftOSYpiSJUXIsz912kwSXsExHH2oMkxDNzETuew0YWceNFifEp6AifBcnG35GBhGLhuy0zZqiUBxv47MNmQd8TzDqLYl1Yrwn0G+90A9xfNitLgBIxuEXTU6VPNdY6Y7cnbkDwre8Z1DBP X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123555025)(20161123562025)(20161123560025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CO1PR15MB1077;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CO1PR15MB1077; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CO1PR15MB1077;4:mS/7rXXfGDGTQPtAuUAw/X07u+MmB3oaFZ3mzOxL6M?= =?us-ascii?Q?EfImiTI7nqsV5QA39yENRyRtlM50fVVfLA1SDUJeXdaOS25pSKEoK2SYBTko?= =?us-ascii?Q?AHXFZqGdLi55rfIpM+2Pq5M9raNtOh2lSd6xd95gwP1SGyS1U0RXmiLpuo47?= =?us-ascii?Q?tZsLn/68YZGwiQ7ht1HSRZD2RO8gczUtkZ66RV4DVd/xfqlcvm0tvRSpGp49?= =?us-ascii?Q?6Ym6+zSamz/MdeFnPL4E98fWMP+xkPqVJ/kxciT3bFiEzaKCPtzBDqS+osHk?= =?us-ascii?Q?lOHj2Udt/AirKBYQRi3clfwJIvAdClR8q7TE4Bx2If+WGcfISd7WL5XqhH5t?= =?us-ascii?Q?51Vnrz/qM8Qcy8IxBwfP8UMoKk6NtnmjL/KsWoAvh55k3E91T9IjnPNz4oCl?= =?us-ascii?Q?RDfYgtBdY3WRFD7VVVSKJxrLtZfMA74dPEcrvCoQoZBnG+M/xMA8G+aw8qcw?= =?us-ascii?Q?5i9wFO7uGaszAGsgwroQrzuBZy+8hMaApO+F+ypoOBM1vPB2d/C0Agia0NDj?= =?us-ascii?Q?JD6ZgMiABLIrVNHPr3vFUhrUf+oSVIH8Lu2JILodpeqw9QS7Wiwqu9K8mXsz?= =?us-ascii?Q?V9R0ghB0cCGRjN1BlUsnGi+ZPb4dnkBPDP0/uxDnP3ZVUYONNMUpQgIb+Jqy?= =?us-ascii?Q?rua6K61z85Ihq5bMVfHU4a/Kabq+ZoU44TWoPKW+u/1Yd988a8sDlAIMJJtx?= =?us-ascii?Q?wIhK+cnJ5omu3vmG13tb709rsvLw9NpojY47fUp1a5Nd20VZYHTUtS4rVaTb?= =?us-ascii?Q?Pq4QtCi/2lTG2TX8X53DSuV5cBxmCF7seq1VyuEGI4NOumYAqh7NRUPhMExm?= =?us-ascii?Q?0mBk6/oP3nty4Fu8+o+G2k5B/uvoqMqKQHJt5FqBswMK6GzQv35AeV24aJ3o?= =?us-ascii?Q?0sJ3RZD0LtN+UXy1LnML6clV2OSZJAMNBVMvnx8/aoJvz5v3EReMzqJjd7KZ?= =?us-ascii?Q?4LYUk/eKFxc91GZrmad0z26/nMDZKnTEBPUNIvynR2OsbUbA0lWRLT5h1ykS?= =?us-ascii?Q?vKuFzx5Au15s5eWarJSaO5ggipU1+46DL2V+HUk/CQR9pgfMn3hB4PNPl7vn?= =?us-ascii?Q?QUu6veDzeURvAlEMD4eN6XPn9zjocWxuZPKIElvTVBau4tobdwjG7+95gmvB?= =?us-ascii?Q?wWWiUiq2FT4QiLfhw0gCwBwudhkShz?= X-Forefront-PRVS: 0386B406AA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(7370300001)(4630300001)(6009001)(39850400002)(39450400003)(39410400002)(39840400002)(39400400002)(24454002)(199003)(377424004)(189002)(2950100002)(6666003)(6916009)(189998001)(9686003)(6116002)(53936002)(47776003)(105586002)(68736007)(42186005)(25786009)(229853002)(478600001)(4001350100001)(4326008)(6506006)(55016002)(38730400002)(110136004)(6246003)(97736004)(54906002)(81156014)(81166006)(7736002)(23726003)(305945005)(8676002)(83506001)(7416002)(5660300001)(33656002)(93886004)(50466002)(1076002)(101416001)(76176999)(7350300001)(54356999)(50986999)(86362001)(2906002)(106356001)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:CO1PR15MB1077;H:castle.DHCP.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CO1PR15MB1077;23:5CsAl7fL/e0338/Rh5TFO4y2FWNX43BszvIeEpZOn?= =?us-ascii?Q?HUXgBYLgOeoczHMAkj787vyfsu8GfhDA7XXyVUTz6vRah3K1YiHAeVRLUUFi?= =?us-ascii?Q?fEk14sjxHqQ13v009a7QuxKT1IZltkLyk8nmvwwcddf2KYB4+OfMdjTuG3nx?= =?us-ascii?Q?bZclKDL3Zh5gp6CV2Rq/SqPuW6Y7Z/hB6GBCNlgbBp1aWauC0rOQfqRmgVPE?= =?us-ascii?Q?nflH0Jq2qHlbJMwSPF+hS7/Q/hrH+BXrn76Zpe2+1ugtrmLd4j9On7L5ZSX6?= =?us-ascii?Q?q49Gj27cJ/z1y9Z/K+ExV/E1PpTB5oczVIKGug0OK/wNHsbA2Wu/hl7K4iHC?= =?us-ascii?Q?n0u1+jL4PUQq+8hJPheVA0+r5Ga4khPJScq8JPWvaTUrJcg+LeCo1BUIqxjl?= =?us-ascii?Q?4qXsHkWpmT6Qi9dwazHXEVIQv6a9VfKWbRB06XBC7hBBBAPf9R8VGwAgUvEy?= =?us-ascii?Q?CZ3OLSfO0bIe/NLdNCM22ATs6eeBghVF2FbZZM0W0kHziYVb9ypg8Yt7YTZB?= =?us-ascii?Q?eiqS9s+pHzdQGGu9jIoNk5H1M2A++n7dZght0I1uZSZ4kQApZKnvHFGYH4/6?= =?us-ascii?Q?1YVVVzHUydA1am1WyB7hLb4d3CSoWu8WrL9efNUWoz1cN8OhfsH9xzt4Bzga?= =?us-ascii?Q?S4Ni6+gUg++/lx+LzpWG8zeCl4StmNJ4+5QTJc9UioDMqPm8oX5y6SvB6Hkc?= =?us-ascii?Q?IwXXv+mGGw63Kp+gFYmY9abClubmYi9EM9T3IOdXW/LORfpQm3m717FDXrZR?= =?us-ascii?Q?QnHGILkm//j702pTZ7A5Ql6bOj2Ir4qOQlZN0LOJaugoWWV5MYgkMcYd0DbP?= =?us-ascii?Q?cgf86K/0sFTdwmfh5bLLDmn29yIJHXK6P6/30aQRQqogejnXAZEe5lKZDsgZ?= =?us-ascii?Q?d04c6uuxNjXqP07ec80H68ckvT4MdnltbBwJdSVqclg0WpB6G3cwJsJyMLwx?= =?us-ascii?Q?axY3sVfDZilieP5EDsmTUSOGzRgSEHHZtbPkJapOKdguYnRfclrstcIM3izF?= =?us-ascii?Q?xYI3GX9FbxMJ1yaoZVh4/zkGIiCILyD+xDV5/ZhdotKqW0NDLy0ldKxgWJQj?= =?us-ascii?Q?/fRkJaDjY7dBhfVLcRIAqr7RFXPV1jjzbQFulj3GBM5b84UkJ/VZiyKW6Mxb?= =?us-ascii?Q?+msqlmJ9jq75qOMWZawVihk5B7DFEYvE5KwN723GH5YZPknDfYVTPUVA39xn?= =?us-ascii?Q?fPSSSV/13PtL2LhRGKQe3TewnafZ2o/bOHNvZaEHBj9gzXzpRKseRwvUuh0a?= =?us-ascii?Q?6M6BYtH4gd5N7t0fHPtJO3/QNipVxn8sWVED/VruP/ieBCjyfBuxkyJ6pCJt?= =?us-ascii?Q?z5b90fwYLix4MD4IvpzjksA6q00ZHINX+FYWUFMYbSn+8mh1Hg4xOCVpWiSX?= =?us-ascii?Q?Ig+9G7GaCCzIH68SBpiP3HDtzThsmWYqUOCAg8lIqt04V7cBAhl+BS5C6x6s?= =?us-ascii?Q?F9Jlna/Lw=3D=3D?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CO1PR15MB1077;6:rkjK5IsYAFiUR2ZQp06GzAW5N9AHzoqq8oUthtAzYL?= =?us-ascii?Q?wE4x50HzdnLrk2XP1dbqBgSib0BxL036HzNdXI064QuWEUtXgQhkY/EJZWqU?= =?us-ascii?Q?BzWq5xwzzw7uvzL3dwHB//+7rqtaPkQiRBtAWqernwEZ6uqnbT4BpUTvtcBv?= =?us-ascii?Q?1iW99Jbl95E9Pqk/7pDiwfU+lkKC10CdRcoExsM86ljJNF6GRhYdUk5sQNeZ?= =?us-ascii?Q?FpRru2mAi7h63rEXsnGt9wJnVGdndDVAsUnNBvLZqIiRy1sG6aSISuM1v0Y1?= =?us-ascii?Q?racHCwhZtoZ4FL0y4hQNzg81lZAjvRjF6fpkG86uRqNkVFAILhoHG2wK76Ss?= =?us-ascii?Q?JvgdoxrTFuTbJpiy1+SeKefZbPq5xVAS0TRsXCU7vfgo3Nnf3g6hV4xSEtia?= =?us-ascii?Q?nbx718zvyX5TjYI/ecvcogxWl2djz0w/xeY3XMpWWyavupQGpYBCslWjsvbn?= =?us-ascii?Q?GID5jbhAgMBK/UcpBhUn3vP0hSPYkb1xQLj7588lkUsv5RqUClo3tgXFXVvw?= =?us-ascii?Q?crF4tu+aAUxwizyXnNfE9ePNV+EdMzsrYeEtHtIpf51NAe8j+dcKif8cAMpu?= =?us-ascii?Q?IT7K2N2+aBher34lax3GAQ1Qm/4Fow6LRuizQL88RJ5K21636IktAkYRGfq4?= =?us-ascii?Q?7gFCACIbboVPFDWNxn6JbcY/enVgieCldvOvmgopM6Z4MKeXw1tQ5Hj3JEEs?= =?us-ascii?Q?Zu2eNm+XiO4WlVfKBgY9x2D7X2UGZqCK618+nBoYlA83gjkfRtjTSt8wSdU0?= =?us-ascii?Q?a/693AKOUWGnZQ/tyrD+YQpxjocvKFyOZvQoNd10FwTSW4RUu9Z2jRuPtJdb?= =?us-ascii?Q?gq0ZHM+Geaj+SGKMzrqUWhByBxN+xSgpO2KjyYSDab+iyTGjmPRst0f5n/U5?= =?us-ascii?Q?t9PpuYG90QPyVDTE06eAsIGaEe1VkEOoo7Vgfy+18r7KX68GDENPezfb8gbV?= =?us-ascii?Q?qLP3UcsPztc156ZQ065i7OiCbUTyZR0+4nXrzyony8EWYEOwHU/sogibrOeE?= =?us-ascii?Q?0=3D?= X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1077;5:RGk2myDlv+jq615n/p/LrkNzDvF016NUwRe3dIYRB53n4Hl6ctkbvN3kdNdiu6XayrezDhPghh2JP5ZirTbf2z676K6vJiy4JJq+cPqm/OSp1sromTfhF+g/LaBKw29cbr3AIgASArK1gg+QiFBctr5ByAkwnuBs9Z9VmjHpVwQnlASj//Li4CNZ1bfT/sHqzXq1D+JdrAjr80H+tNchJMRDkPB7QWK/qYNXlDu8e6TB7PL8SOFykksBQHAl5oOdtdwgEDmCY6f3HF8Fj0mSG9Y1R/1AIaK4M/QcTBRttyzY/mQb3C0or2QfvSHJOKDgTBoSL8vmuirTJTUe/ycwudBVAvP+QEvt3Wzpxt7Hlz4C03rFmjYKeGvhM72/bGFRUA25CWL4E0H2uFRQYGsXDd6y4bW5GG77fRfaZm/l0h9pxdDzE1R0Fm7nLzpl6bcito8YP5T/V2baAKAWJhhRQpgmsPKHZEfTh24bYMM6XG3L4vIgRfBUyMKItL5Si1G7;24:2t2ILpaQGDCqLsXI0Xx/Z5BvOAVd3Lo0tz8QdtxSTQvu4Swy7PY9EK4tTNmD2vf+6S2RCcZR7yiLrfzYwr06ExbYL25fCc5kkJHxuNFg5zE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1077;7:yNXv5sfObJGA33c5wFjJgRdG2Dn2aebcANBi+qvdBIhXzaDp4ooeos+ewlgkWMjptuCLiukFnSkiSxVufotfom+GLmZda49+Q6fWyj/uFdnki66xsnrNVQmp2y+slsOCdeWFTr+y7GEFbfVvrEIjYCkSyiImA6dSOrBYyyurp4rwiO8wbkeYCi4TPbTY41O4M50hQL7K4Q8jnVb3oTzdw+TLc4tcnb3s3R9M1SeQrufO8tf2acs+nh/5rUQj8CXgnUSGRqurdrF5OxHJZO3VjS+gct55CS3bnTng56JSoCBuU6B+H78fQQ/j9tjge+aa/S4G2jH62phOxF9uNxdR1MlyREerEm5CQYHvGRGrg8LGlRvxZJC64L6ed45eZKChrDJZNlhvSCqkgLEcQ16FNxsZyyLHHsz2HmQ3tNip948061/5yD066jay2e8qZ17V6sy4kR1m0LKYOGs+YBowhiCIRQm838sbq/2wOIuL0Z1PvhptsOs/8vwlVsKd2Dtxw5X07XFf58Id5cuIDDq5OifsbpidYCKcEoJhHEQMHyoeRycOdwGsbAEMTfpk112A60uZih787Edk+w0Lh+Ax7LMYcyGPlcG3PkV3kjLGGIKx6yiSWS+0i6Ge8i8OD8d6By4/txqSbiv9MaydSBpwbw2D5zS1SKuLqp9Q30Z3GjYBGRF4+UjfLXv22XAc8Y7ssnwU8nkLk0wQAuk7NjmvaldjH2PAZbkd1DMianhSI+bAQHNpjhfLO6RRxDsTderHMnBNPySNcH4HNzt6FWACq8C4vAgIkuDFeR+Jq4RJBLk= X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1077;20:1NDI3GS6h+gwFT1+B8T5IyG+kT+kC/MumAonpPIn5yB9CCzq7sUtrMRX+/pzyGg6kCtfpIVctDIcup8pL4JyK1QkzLy8u3mQeHhh6aWWGMlaD+sjfvSixYPpRb+XWk/FoQ90054TL7God2GNMmLS+BRmY2pOTmNTTHXVvU5ie90= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2017 18:14:03.7999 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR15MB1077 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-01_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 01, 2017 at 07:03:03PM +0200, Michal Hocko wrote: > On Tue 01-08-17 16:25:48, Roman Gushchin wrote: > > On Tue, Aug 01, 2017 at 04:54:35PM +0200, Michal Hocko wrote: > [...] > > > I would reap out the oom_kill_process into a separate patch. > > > > It was a separate patch, I've merged it based on Vladimir's feedback. > > No problems, I can divide it back. > > It would make the review slightly more easier > > > > > > -static void oom_kill_process(struct oom_control *oc, const char *message) > > > > +static void __oom_kill_process(struct task_struct *victim) > > > > > > To the rest of the patch. I have to say I do not quite like how it is > > > implemented. I was hoping for something much simpler which would hook > > > into oom_evaluate_task. If a task belongs to a memcg with kill-all flag > > > then we would update the cumulative memcg badness (more specifically the > > > badness of the topmost parent with kill-all flag). Memcg will then > > > compete with existing self contained tasks (oom_badness will have to > > > tell whether points belong to a task or a memcg to allow the caller to > > > deal with it). But it shouldn't be much more complex than that. > > > > I'm not sure, it will be any simpler. Basically I'm doing the same: > > the difference is that you want to iterate over tasks and for each > > task traverse the memcg tree, update per-cgroup oom score and find > > the corresponding memcg(s) with the kill-all flag. I'm doing the opposite: > > traverse the cgroup tree, and for each leaf cgroup iterate over processes. > > Yeah but this doesn't fit very well to the existing scheme so we would > need two different schemes which is not ideal from maint. point of view. > We also do not have to duplicate all the tricky checks we already do in > oom_evaluate_task. So I would prefer if we could try to hook there and > do the special handling there. I hope, that iterating over all tasks just to check if there are in-flight OOM victims might be optimized at some point. That means, we would be able to choose a victim much cheaper. It's not easy, but it feels as a right direction to go. Also, adding new tricks to the oom_evaluate_task() will make the code even more hairy. Some of the existing tricks are useless for memcg selection. > > > Also, please note, that even without the kill-all flag the decision is made > > on per-cgroup level (except tasks in the root cgroup). > > Yeah and I am not sure this is a reasonable behavior. Why should we > consider memcgs which are not kill-all as a single entity? I think, it's reasonable to choose a cgroup/container to blow off based on the cgroup oom_priority/size (including hierarchical settings), and then kill one biggest or all tasks depending on cgroup settings. Thanks!