From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752968AbdHBKqh (ORCPT <rfc822;w@1wt.eu>);
        Wed, 2 Aug 2017 06:46:37 -0400
Received: from ganesha.gnumonks.org ([213.95.27.120]:50590 "EHLO
        ganesha.gnumonks.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751192AbdHBKqg (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 2 Aug 2017 06:46:36 -0400
Date: Wed, 2 Aug 2017 12:46:10 +0200
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
        Harald Welte <laforge@gnumonks.org>,
        "open list:GTP (GPRS Tunneling Protocol)" 
        <osmocom-net-gprs@lists.osmocom.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 5/7] gtp: Initialize 64-bit per-cpu stats correctly
Message-ID: <20170802104610.GA2566@salvia>
References: <20170801191113.8754-1-f.fainelli@gmail.com>
 <20170801191113.8754-6-f.fainelli@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170801191113.8754-6-f.fainelli@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.7 (--)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 01, 2017 at 12:11:10PM -0700, Florian Fainelli wrote:
> On 32-bit hosts and with CONFIG_DEBUG_LOCK_ALLOC we should be seeing a
> lockdep splat indicating this seqcount is not correctly initialized, fix
> that by using netdev_alloc_pcpu_stats() instead of an open coded
> allocation.
> 
> Fixes: 459aa660eb1d ("gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>

Thanks!