From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753255AbdHBMYf (ORCPT ); Wed, 2 Aug 2017 08:24:35 -0400 Received: from ganesha.gnumonks.org ([213.95.27.120]:51400 "EHLO ganesha.gnumonks.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753046AbdHBMYd (ORCPT ); Wed, 2 Aug 2017 08:24:33 -0400 Date: Wed, 2 Aug 2017 14:23:55 +0200 From: Pablo Neira Ayuso To: Julia Lawall Cc: "David S. Miller" , kernel-janitors@vger.kernel.org, Jozsef Kadlecsik , Florian Westphal , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1 v3 nf-next] netfilter: constify nf_conntrack_l3/4proto parameters Message-ID: <20170802122355.GA13459@salvia> References: <1501583101-14188-1-git-send-email-Julia.Lawall@lip6.fr> <1501583101-14188-2-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501583101-14188-2-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 01, 2017 at 12:25:01PM +0200, Julia Lawall wrote: > When a nf_conntrack_l3/4proto parameter is not on the left hand side > of an assignment, its address is not taken, and it is not passed to a > function that may modify its fields, then it can be declared as const. > > This change is useful from a documentation point of view, and can > possibly facilitate making some nf_conntrack_l3/4proto structures const > subsequently. > > Done with the help of Coccinelle. Applied, thanks Julia.