From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752009AbdHBVRO (ORCPT ); Wed, 2 Aug 2017 17:17:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:39790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775AbdHBVRM (ORCPT ); Wed, 2 Aug 2017 17:17:12 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1EB82392A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mcgrof@kernel.org From: "Luis R. Rodriguez" To: akpm@linux-foundation.org Cc: dmitry.torokhov@gmail.com, keescook@chromium.org, jeyu@redhat.com, rusty@rustcorp.com.au, mmarek@suse.com, pmladek@suse.com, mbenes@suse.cz, jpoimboe@redhat.com, ebiederm@xmission.com, shuah@kernel.org, dan.carpenter@oracle.com, colin.king@canonical.com, dcb314@hotmail.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, "Luis R . Rodriguez" Subject: [PATCH 2/2] test_kmod: flip INT checks to be consistent Date: Wed, 2 Aug 2017 14:17:07 -0700 Message-Id: <20170802211707.28020-3-mcgrof@kernel.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170802211707.28020-1-mcgrof@kernel.org> References: <20170802211707.28020-1-mcgrof@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter Most checks will check for min and then max, except the int check. Flip the checks to be consistent with the other code. Signed-off-by: Dan Carpenter [mcgrof: massaged commit log] Signed-off-by: Luis R. Rodriguez --- lib/test_kmod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_kmod.c b/lib/test_kmod.c index 67fc7b9f41e3..fba78d25e825 100644 --- a/lib/test_kmod.c +++ b/lib/test_kmod.c @@ -946,7 +946,7 @@ static int test_dev_config_update_int(struct kmod_test_device *test_dev, if (ret) return ret; - if (new > INT_MAX || new < INT_MIN) + if (new < INT_MIN || new > INT_MAX) return -EINVAL; mutex_lock(&test_dev->config_mutex); -- 2.11.0