From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751743AbdHBV2N (ORCPT ); Wed, 2 Aug 2017 17:28:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42604 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbdHBV2M (ORCPT ); Wed, 2 Aug 2017 17:28:12 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com ACB1981235 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=mst@redhat.com Date: Thu, 3 Aug 2017 00:28:10 +0300 From: "Michael S. Tsirkin" To: Bhumika Goyal Cc: julia.lawall@lip6.fr, somlo@cmu.edu, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org Subject: Re: [PATCH] firmware: add const to bin_attribute structures Message-ID: <20170803002709-mutt-send-email-mst@kernel.org> References: <1501663295-18774-1-git-send-email-bhumirks@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501663295-18774-1-git-send-email-bhumirks@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 02 Aug 2017 21:28:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 02, 2017 at 02:11:35PM +0530, Bhumika Goyal wrote: > Add const to bin_attribute structures as they are only passed to the > functions sysfs_{remove/create}_bin_file. The arguments passed are of > type const, so declare the structures to be const. > > Done using Coccinelle. > > @m disable optional_qualifier@ > identifier s; > position p; > @@ > static struct bin_attribute s@p={...}; > > @okay1@ > position p; > identifier m.s; > @@ > ( > sysfs_create_bin_file(...,&s@p,...) > | > sysfs_remove_bin_file(...,&s@p,...) > ) > > @bad@ > position p!={m.p,okay1.p}; > identifier m.s; > @@ > s@p > > @change depends on !bad disable optional_qualifier@ > identifier m.s; > @@ > static > +const > struct bin_attribute s={...}; > > Signed-off-by: Bhumika Goyal For qemu bits: Acked-by: Michael S. Tsirkin Feel free to merge., > --- > drivers/firmware/dell_rbu.c | 6 +++--- > drivers/firmware/dmi-sysfs.c | 2 +- > drivers/firmware/google/gsmi.c | 2 +- > drivers/firmware/google/memconsole.c | 2 +- > drivers/firmware/qemu_fw_cfg.c | 2 +- > 5 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/firmware/dell_rbu.c b/drivers/firmware/dell_rbu.c > index 2f452f1..a771360 100644 > --- a/drivers/firmware/dell_rbu.c > +++ b/drivers/firmware/dell_rbu.c > @@ -675,18 +675,18 @@ static ssize_t write_rbu_packet_size(struct file *filp, struct kobject *kobj, > return count; > } > > -static struct bin_attribute rbu_data_attr = { > +static const struct bin_attribute rbu_data_attr = { > .attr = {.name = "data", .mode = 0444}, > .read = read_rbu_data, > }; > > -static struct bin_attribute rbu_image_type_attr = { > +static const struct bin_attribute rbu_image_type_attr = { > .attr = {.name = "image_type", .mode = 0644}, > .read = read_rbu_image_type, > .write = write_rbu_image_type, > }; > > -static struct bin_attribute rbu_packet_size_attr = { > +static const struct bin_attribute rbu_packet_size_attr = { > .attr = {.name = "packet_size", .mode = 0644}, > .read = read_rbu_packet_size, > .write = write_rbu_packet_size, > diff --git a/drivers/firmware/dmi-sysfs.c b/drivers/firmware/dmi-sysfs.c > index d5de6ee..936e656 100644 > --- a/drivers/firmware/dmi-sysfs.c > +++ b/drivers/firmware/dmi-sysfs.c > @@ -440,7 +440,7 @@ static ssize_t dmi_sel_raw_read(struct file *filp, struct kobject *kobj, > return find_dmi_entry(entry, dmi_sel_raw_read_helper, &state); > } > > -static struct bin_attribute dmi_sel_raw_attr = { > +static const struct bin_attribute dmi_sel_raw_attr = { > .attr = {.name = "raw_event_log", .mode = 0400}, > .read = dmi_sel_raw_read, > }; > diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c > index c8f169b..1ad29f7 100644 > --- a/drivers/firmware/google/gsmi.c > +++ b/drivers/firmware/google/gsmi.c > @@ -508,7 +508,7 @@ static ssize_t eventlog_write(struct file *filp, struct kobject *kobj, > > } > > -static struct bin_attribute eventlog_bin_attr = { > +static const struct bin_attribute eventlog_bin_attr = { > .attr = {.name = "append_to_eventlog", .mode = 0200}, > .write = eventlog_write, > }; > diff --git a/drivers/firmware/google/memconsole.c b/drivers/firmware/google/memconsole.c > index 166f07c..b11a02c 100644 > --- a/drivers/firmware/google/memconsole.c > +++ b/drivers/firmware/google/memconsole.c > @@ -33,7 +33,7 @@ static ssize_t memconsole_read(struct file *filp, struct kobject *kobp, > return memconsole_read_func(buf, pos, count); > } > > -static struct bin_attribute memconsole_bin_attr = { > +static const struct bin_attribute memconsole_bin_attr = { > .attr = {.name = "log", .mode = 0444}, > .read = memconsole_read, > }; > diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c > index 0e20116..f254977 100644 > --- a/drivers/firmware/qemu_fw_cfg.c > +++ b/drivers/firmware/qemu_fw_cfg.c > @@ -343,7 +343,7 @@ static ssize_t fw_cfg_sysfs_read_raw(struct file *filp, struct kobject *kobj, > return count; > } > > -static struct bin_attribute fw_cfg_sysfs_attr_raw = { > +static const struct bin_attribute fw_cfg_sysfs_attr_raw = { > .attr = { .name = "raw", .mode = S_IRUSR }, > .read = fw_cfg_sysfs_read_raw, > }; > -- > 1.9.1