From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752011AbdHCCVR (ORCPT ); Wed, 2 Aug 2017 22:21:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:41312 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751345AbdHCCVP (ORCPT ); Wed, 2 Aug 2017 22:21:15 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31F1D22B64 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org Date: Thu, 3 Aug 2017 10:20:09 +0800 From: Shawn Guo To: Martin Kaiser Cc: Markus Pargmann , Denis Carikli , devicetree@vger.kernel.org, Rob Herring , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc Message-ID: <20170803022007.GI31819@dragon> References: <1501704371-28151-1-git-send-email-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501704371-28151-1-git-send-email-martin@kaiser.cx> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote: > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between > the addresses used by tscadc and those in its child nodes (adc, tsc). > > Without such a mapping, the reg = ... lines in the tsc and adc nodes do > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc > drivers will then fail since there's no IORESOURCE_MEM. > > Signed-off-by: Martin Kaiser Do we need the following Fixes tag? Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support") @Markus, we didn't the changes when we were submitting? Shawn > --- > arch/arm/boot/dts/imx25.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > index 0d2f3a1..1e37bd3 100644 > --- a/arch/arm/boot/dts/imx25.dtsi > +++ b/arch/arm/boot/dts/imx25.dtsi > @@ -297,6 +297,7 @@ > #address-cells = <1>; > #size-cells = <1>; > status = "disabled"; > + ranges; > > adc: adc@50030800 { > compatible = "fsl,imx25-gcq"; > -- > 2.1.4 >