From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751983AbdHCQaS (ORCPT ); Thu, 3 Aug 2017 12:30:18 -0400 Received: from botnar.kaiser.cx ([176.28.20.183]:53944 "EHLO botnar.kaiser.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751956AbdHCQaR (ORCPT ); Thu, 3 Aug 2017 12:30:17 -0400 Date: Thu, 3 Aug 2017 18:29:48 +0200 From: Martin Kaiser To: Shawn Guo Cc: Markus Pargmann , Denis Carikli , devicetree@vger.kernel.org, Rob Herring , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc Message-ID: <20170803162948.GA28042@botnar.kaiser.cx> References: <1501704371-28151-1-git-send-email-martin@kaiser.cx> <20170803022007.GI31819@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170803022007.GI31819@dragon> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, Thus wrote Shawn Guo (shawnguo@kernel.org): > On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote: > > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between > > the addresses used by tscadc and those in its child nodes (adc, tsc). > > Without such a mapping, the reg = ... lines in the tsc and adc nodes do > > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc > > drivers will then fail since there's no IORESOURCE_MEM. > > Signed-off-by: Martin Kaiser > Do we need the following Fixes tag? > Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support") yes, looks like this has never worked correctly. If you're ok with the fix, I can add the tag in v2. > @Markus, we didn't the changes when we were submitting? Both Markus' and Denis' mail addresses bounced... Best regards, Martin