Re: [PATCH RFC 1/2] KVM: x86: generalize guest_cpuid_has_ helpers

Radim Krčmář
2017-08-04T20:48:38Z

2017-08-04 17:40+0200, Paolo Bonzini:
> Wow, I didn't expect the compiler to be able to inline all of this and
> even do BUILD_BUG_ON()s on array lookups. Maybe change inline to
> __always_inline just to be safe?
>
> If anybody complains we can make it just a BUG.

Good point, i386 wanted to have non-inlined guest_cpuid_get_register(),
but I hope that __always_inline is going to be enough for all.

Thanks.