Re: [PATCH RFC 0/2] KVM: x86: generalize guest cpuid helpers

David Hildenbrand
2017-08-03T11:53:10Z

On 02.08.2017 22:41, Radim Krčmář wrote:
> This series does the generalization that we've spoken about recently
> Might be a good time to change the function names as well.
>
>
> Radim Krčmář (2):
> KVM: x86: generalize guest_cpuid_has_ helpers
> KVM: x86: use general helpers for some cpuid manipulation
>
> arch/x86/kvm/cpuid.h | 205 ++++++++++++++++++---------------------------------
> arch/x86/kvm/mmu.c | 7 +-
> arch/x86/kvm/mtrr.c | 2 +-
> arch/x86/kvm/svm.c | 7 +-
> arch/x86/kvm/vmx.c | 33 ++++-----
> arch/x86/kvm/x86.c | 52 ++++++-------
> 6 files changed, 116 insertions(+), 190 deletions(-)
>

These numbers speak for themselves.

I really like this cleanup!

Had a quick look over the patches, nothing jumped at me.

--

Thanks,

David