From: Dave Chinner <david@fromorbit.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: darrick.wong@oracle.com, Jan Kara <jack@suse.cz>,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, Jeff Moyer <jmoyer@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
luto@kernel.org, linux-fsdevel@vger.kernel.org,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 2/5] fs, xfs: introduce FALLOC_FL_SEAL_BLOCK_MAP
Date: Sat, 5 Aug 2017 09:31:40 +1000 [thread overview]
Message-ID: <20170804233140.GF21024@dastard> (raw)
In-Reply-To: <150181369754.32119.7390149918955188408.stgit@dwillia2-desk3.amr.corp.intel.com>
On Thu, Aug 03, 2017 at 07:28:17PM -0700, Dan Williams wrote:
> diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c
> index fe0f8f7f4bb7..46d8eb9e19fc 100644
> --- a/fs/xfs/xfs_bmap_util.c
> +++ b/fs/xfs/xfs_bmap_util.c
> @@ -1393,6 +1393,107 @@ xfs_zero_file_space(
>
> }
>
> +/* Return 1 if hole detected, 0 if not, and < 0 if fail to determine */
> +STATIC int
> +xfs_file_has_holes(
> + struct xfs_inode *ip)
> +{
Why do we need this function?
We've just run xfs_alloc_file_space() across the entire range we
are sealing, so we've already guaranteed that it won't have holes
in it.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-08-04 23:31 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 2:28 [PATCH v2 0/5] fs, xfs: block map immutable files for dax, dma-to-storage, and swap Dan Williams
2017-08-04 2:28 ` [PATCH v2 1/5] fs, xfs: introduce S_IOMAP_IMMUTABLE Dan Williams
2017-08-04 20:00 ` Darrick J. Wong
2017-08-04 20:31 ` Dan Williams
2017-08-05 9:47 ` Christoph Hellwig
2017-08-07 0:25 ` Dave Chinner
2017-08-11 10:34 ` Christoph Hellwig
2017-08-04 2:28 ` [PATCH v2 2/5] fs, xfs: introduce FALLOC_FL_SEAL_BLOCK_MAP Dan Williams
2017-08-04 19:46 ` Darrick J. Wong
2017-08-04 19:52 ` Dan Williams
2017-08-04 23:31 ` Dave Chinner [this message]
2017-08-04 23:43 ` Dan Williams
2017-08-05 0:04 ` Dave Chinner
2017-08-04 2:28 ` [PATCH v2 3/5] fs, xfs: introduce FALLOC_FL_UNSEAL_BLOCK_MAP Dan Williams
2017-08-04 20:04 ` Darrick J. Wong
2017-08-04 20:36 ` Dan Williams
2017-08-04 2:28 ` [PATCH v2 4/5] xfs: introduce XFS_DIFLAG2_IOMAP_IMMUTABLE Dan Williams
2017-08-04 20:33 ` Darrick J. Wong
2017-08-04 20:45 ` Dan Williams
2017-08-04 23:46 ` Dave Chinner
2017-08-04 23:57 ` Darrick J. Wong
2017-08-04 2:28 ` [PATCH v2 5/5] xfs: toggle XFS_DIFLAG2_IOMAP_IMMUTABLE in response to fallocate Dan Williams
2017-08-04 20:14 ` Darrick J. Wong
2017-08-04 20:47 ` Dan Williams
2017-08-04 20:53 ` Darrick J. Wong
2017-08-04 20:55 ` Dan Williams
2017-08-04 2:38 ` [PATCH v2 0/5] fs, xfs: block map immutable files for dax, dma-to-storage, and swap Dan Williams
2017-08-05 9:50 ` Christoph Hellwig
2017-08-06 18:51 ` Dan Williams
2017-08-11 10:44 ` Christoph Hellwig
2017-08-11 22:26 ` Dan Williams
2017-08-12 3:57 ` Andy Lutomirski
2017-08-12 4:44 ` Dan Williams
2017-08-12 7:34 ` Christoph Hellwig
2017-08-12 7:33 ` Christoph Hellwig
2017-08-12 19:19 ` Dan Williams
2017-08-13 9:24 ` Christoph Hellwig
2017-08-13 20:31 ` Dan Williams
2017-08-14 12:40 ` Jan Kara
2017-08-14 16:14 ` Dan Williams
2017-08-15 8:37 ` Jan Kara
2017-08-15 23:50 ` Dan Williams
2017-08-16 13:57 ` Jan Kara
2017-08-21 9:16 ` Peter Zijlstra
2017-08-14 21:46 ` Darrick J. Wong
2017-08-13 23:46 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804233140.GF21024@dastard \
--to=david@fromorbit.com \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=luto@kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox