From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751355AbdHEFcg (ORCPT <rfc822;w@1wt.eu>);
        Sat, 5 Aug 2017 01:32:36 -0400
Received: from mail.kernel.org ([198.145.29.99]:60866 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751184AbdHEFcf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 5 Aug 2017 01:32:35 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E05E822C95
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org
Date: Sat, 5 Aug 2017 13:31:24 +0800
From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Markus Pargmann <mpa@pengutronix.de>, Denis Carikli <denis@eukrea.com>,
        devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc
Message-ID: <20170805053122.GR31819@dragon>
References: <1501704371-28151-1-git-send-email-martin@kaiser.cx>
 <20170803022007.GI31819@dragon>
 <20170803162948.GA28042@botnar.kaiser.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170803162948.GA28042@botnar.kaiser.cx>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 03, 2017 at 06:29:48PM +0200, Martin Kaiser wrote:
> Hi Shawn,
> 
> Thus wrote Shawn Guo (shawnguo@kernel.org):
> 
> > On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote:
> > > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between
> > > the addresses used by tscadc and those in its child nodes (adc, tsc).
> 
> > > Without such a mapping, the reg = ... lines in the tsc and adc nodes do
> > > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc
> > > drivers will then fail since there's no IORESOURCE_MEM.
> 
> > > Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> 
> > Do we need the following Fixes tag?
> 
> > Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support")
> 
> yes, looks like this has never worked correctly.
> 
> If you're ok with the fix, I can add the tag in v2.

I added the Fixes tag and applied the patch.  Thanks.

Shawn