From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752084AbdHGHI0 (ORCPT ); Mon, 7 Aug 2017 03:08:26 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33177 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901AbdHGHIZ (ORCPT ); Mon, 7 Aug 2017 03:08:25 -0400 Date: Mon, 7 Aug 2017 00:08:07 -0700 From: Nicolin Chen To: Stefan Agner Cc: timur@tabi.org, Xiubo.Lee@gmail.com, fabio.estevam@nxp.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: fsl_asrc: protect macro argument Message-ID: <20170807070806.GA8208@Asurada> References: <20170807063657.12581-1-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170807063657.12581-1-stefan@agner.ch> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 06, 2017 at 11:36:57PM -0700, Stefan Agner wrote: > Protect macro argument with parentheses to avoid ambiguity. > This fixes a warning seen with clang: > warning: logical not is only applied to the left hand side of this comparison > > Signed-off-by: Stefan Agner Acked-by: Nicolin Chen Thanks > --- > sound/soc/fsl/fsl_asrc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_asrc.h b/sound/soc/fsl/fsl_asrc.h > index 0f163abe4ba3..ec33dab4b909 100644 > --- a/sound/soc/fsl/fsl_asrc.h > +++ b/sound/soc/fsl/fsl_asrc.h > @@ -57,7 +57,7 @@ > #define REG_ASRDOC 0x74 > #define REG_ASRDI(i) (REG_ASRDIA + (i << 3)) > #define REG_ASRDO(i) (REG_ASRDOA + (i << 3)) > -#define REG_ASRDx(x, i) (x == IN ? REG_ASRDI(i) : REG_ASRDO(i)) > +#define REG_ASRDx(x, i) ((x) == IN ? REG_ASRDI(i) : REG_ASRDO(i)) > > #define REG_ASRIDRHA 0x80 > #define REG_ASRIDRLA 0x84 > -- > 2.13.3 >