From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752181AbdHGIG2 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 7 Aug 2017 04:06:28 -0400
Received: from mga07.intel.com ([134.134.136.100]:48200 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751560AbdHGIG1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 7 Aug 2017 04:06:27 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.41,336,1498546800"; 
   d="scan'208";a="1000850447"
Date: Mon, 7 Aug 2017 11:06:23 +0300
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: LKML <linux-kernel@vger.kernel.org>, andreas.noever@gmail.com,
        michael.jamet@intel.com, yehezkel.bernat@intel.com
Subject: Re: [PATCH] thunderbolt: icm: Remove Apple check for Alpine Ridge
Message-ID: <20170807080623.GP2369@lahna.fi.intel.com>
References: <20170807044912.18146-1-kai.heng.feng@canonical.com>
 <CAAd53p5c+MHuviVjEi0=oJ0eEE3atW181PsHpCjfqnhtHBy=GA@mail.gmail.com>
 <20170807070254.GL2369@lahna.fi.intel.com>
 <CAAd53p6M0Vh7xsa3UfEV_fmnbXfyi9knUQvbNRkhGdZrHtSEMQ@mail.gmail.com>
 <20170807075150.GN2369@lahna.fi.intel.com>
 <CAAd53p6uJ_LRtLycay=bQG1TsnWeDcKx_b6ZK650-m91vMHWAg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAAd53p6uJ_LRtLycay=bQG1TsnWeDcKx_b6ZK650-m91vMHWAg@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 07, 2017 at 04:00:06PM +0800, Kai-Heng Feng wrote:
> On Mon, Aug 7, 2017 at 3:51 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > At this point we should find out that the ICM is already running and the
> > function never calls pci2cio_write().
> 
> I guess you mean this code section:
> 
>         /* Check if the ICM firmware is already running */
>         val = ioread32(nhi->iobase + REG_FW_STS);
>         if (val & REG_FW_STS_ICM_EN)
>                 return 0;

Yes, that's correct.